refactor: inline OutputConfigurationExtension into Infrastructure#62
Merged
Merged
Conversation
…cture Remove the OutputConfigurationExtension<T> wrapper class and store the configuration list directly in Infrastructure<TOutputConfiguration, TMetadata>. The extension was a pure data holder with no lifecycle hooks, making the indirection unnecessary. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
NotoriousTest.Core/Extensions/OutputConfigurationExtension.csInfrastructure<TOutputConfiguration, TMetadata>to own the configuration list directlyWhy
OutputConfigurationExtension<T>was a pure data holder — aList<ConfigurationEntry<T>>plus twoAddEntryhelpers — registered as anIInfrastructureExtensionwithout implementing any lifecycle hooks (OnBeforeInitialize, etc.). The extension mechanism added indirection with no benefit. The list and methods now live directly in theInfrastructure<TOutputConfiguration, TMetadata>class.What reviewers should know
OutputConfiguration,AddEntry(key, value), andAddEntry(value)are all still present on the same class.AddEntry(TOutputConfiguration value)overload (previously only on the extension) is now also exposed directly on the class — it was already accessible via the extension before.Infrastructure.csreferencedOutputConfigurationExtensiondirectly.