Skip to content

gephgui-wry: init at 5.4.1#471304

Merged
gepbird merged 1 commit intoNixOS:masterfrom
MCSeekeri:add-gephgui-wry
Jan 25, 2026
Merged

gephgui-wry: init at 5.4.1#471304
gepbird merged 1 commit intoNixOS:masterfrom
MCSeekeri:add-gephgui-wry

Conversation

@MCSeekeri
Copy link
Copy Markdown
Contributor

gephgui-wry, the official GUI for the current version of geph, replaces the deprecated geph-client-gui component in the existing geph package.
After this PR is merged, the geph-client-gui component within the existing geph package will be removed to align with upstream changes.
I hope to distinguish between these two—geph as CLI software and gephgui as GUI software.

The current name references the official repository's nomenclature; I haven't yet conceived a name that explicitly highlights this distinction.

Tested and functional on my device, but I feel the current packaging still doesn't fully align with best practices. Feedback on improvements is welcome.

@penalty1083

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 16, 2025
@MCSeekeri MCSeekeri force-pushed the add-gephgui-wry branch 2 times, most recently from 57c14a9 to 6fbd549 Compare December 16, 2025 09:55
@MCSeekeri MCSeekeri force-pushed the add-gephgui-wry branch 2 times, most recently from e25d587 to 841531a Compare December 24, 2025 08:02
@MCSeekeri
Copy link
Copy Markdown
Contributor Author

Geph has been updated to version 5.4.0, but the master branch has not been updated. I'm wondering if we should switch the branch used for fetching and compiling to next or perform a forced update when fetching submodules.

@MCSeekeri MCSeekeri changed the title gephgui-wry: init at 5.3.1 gephgui-wry: init at 5.4.0 Dec 27, 2025
@penalty1083
Copy link
Copy Markdown
Contributor

5.4.1 has been published. I thought we only need to care about the tag. Why is this marked as draft? Is there anything to fix?

@MCSeekeri
Copy link
Copy Markdown
Contributor Author

5.4.1 has been published. I thought we only need to care about the tag. Why is this marked as draft? Is there anything to fix?

I've been quite busy these days and haven't been able to keep up with the PR status promptly. Once we fix the current issues we're working on, we can take it out of draft status.

@MCSeekeri MCSeekeri force-pushed the add-gephgui-wry branch 2 times, most recently from 3f84ef8 to 307f88f Compare January 2, 2026 06:17
@MCSeekeri MCSeekeri changed the title gephgui-wry: init at 5.4.0 gephgui-wry: init at 5.4.1 Jan 2, 2026
@MCSeekeri MCSeekeri marked this pull request as ready for review January 4, 2026 00:53
@MCSeekeri MCSeekeri requested a review from Prince213 January 7, 2026 09:27
@MCSeekeri MCSeekeri force-pushed the add-gephgui-wry branch 4 times, most recently from e630d47 to baef490 Compare January 13, 2026 08:21
@MCSeekeri
Copy link
Copy Markdown
Contributor Author

Ofborg fails to properly package the executable. This is likely related to the incomplete package-lock.json used upstream in gephgui – since @esbuild depends on different binaries across operating systems. The current solutions are either waiting for the upstream fix or manually modifying package-lock.json.
However, modifying package-lock.json would prevent nixpkgs-update from correctly handling subsequent automated updates...
I’m uncertain how this should be handled.

@gepbird
Copy link
Copy Markdown
Contributor

gepbird commented Jan 24, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 471304
Commit: bd532070d1e78fc8fc9a5a1af0ab31c209afe2db


x86_64-linux

❌ 1 package failed to build:
  • gephgui-wry

Co-authored-by: penalty1083 <penalty1083@outlook.com>
Co-authored-by: gepbird <gutyina.gergo.2@gmail.com>
@gepbird
Copy link
Copy Markdown
Contributor

gepbird commented Jan 25, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 471304
Commit: bd69ab7156ca09b763617299f9f83d6a1ce979a2


x86_64-linux

✅ 1 package built:
  • gephgui-wry

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 25, 2026
@gepbird gepbird enabled auto-merge January 25, 2026 22:17
@gepbird gepbird added this pull request to the merge queue Jan 25, 2026
Merged via the queue into NixOS:master with commit da1b0d0 Jan 25, 2026
31 of 33 checks passed
@MCSeekeri
Copy link
Copy Markdown
Contributor Author

The issue has not been fully resolved yet; compilation on the aarch64 platform still fails due to issues with package-lock.json. However, this can be deferred for now. I have already submitted a PR upstream and hope it gets merged.
geph-official/gephgui#50

@MCSeekeri MCSeekeri added the backport release-25.11 Backport PR automatically label Jan 27, 2026
@nixpkgs-ci
Copy link
Copy Markdown
Contributor

nixpkgs-ci bot commented Jan 27, 2026

Successfully created backport PR for release-25.11:

@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. backport release-25.11 Backport PR automatically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants