Skip to content

geph: remove geph5-client-gui#473540

Merged
gepbird merged 1 commit intoNixOS:masterfrom
MCSeekeri:deprecate-geph5-client-gui
Jan 25, 2026
Merged

geph: remove geph5-client-gui#473540
gepbird merged 1 commit intoNixOS:masterfrom
MCSeekeri:deprecate-geph5-client-gui

Conversation

@MCSeekeri
Copy link
Copy Markdown
Contributor

@MCSeekeri MCSeekeri commented Dec 23, 2025

geph-official/geph5@f2221fb
Remove the deprecated geph5-client-gui. For GUI functionality, please use gephgui-wry instead.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Dec 23, 2025
@qweered
Copy link
Copy Markdown
Contributor

qweered commented Dec 24, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 473540
Commit: 3c396a480367ad4f15b9dcbfb4ffef699ca2177f (subsequent changes)
Merge: c6a3f09cff4d7e808e020cd460898cbddef72222

Logs: https://github.com/qweered/nixpkgs-review-gha/actions/runs/20494373555

x86_64-linux

✅ 1 package built:
  • geph

aarch64-linux

✅ 1 package built:
  • geph

qweered
qweered approved these changes Dec 24, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@qweered qweered left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Dec 24, 2025
@penalty1083
Copy link
Copy Markdown
Contributor

penalty1083 commented Dec 25, 2025

Do we need to add a changelog item?

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Dec 25, 2025
@MCSeekeri MCSeekeri force-pushed the deprecate-geph5-client-gui branch from 3c396a4 to 66263b8 Compare December 25, 2025 10:37
@nixpkgs-ci nixpkgs-ci bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation and removed 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 25, 2025
@MCSeekeri MCSeekeri force-pushed the deprecate-geph5-client-gui branch from 66263b8 to 2c3bb6c Compare December 28, 2025 09:40
@MCSeekeri MCSeekeri force-pushed the deprecate-geph5-client-gui branch from 2c3bb6c to 03e4b57 Compare January 7, 2026 12:28
gepbird
gepbird reviewed Jan 23, 2026
View reviewed changes
@gepbird
Copy link
Copy Markdown
Contributor

gepbird commented Jan 25, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 473540
Commit: 03e4b579841a00a51e4767701321db3cad8c4e63

x86_64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 1 package built:
  • geph

gepbird
gepbird approved these changes Jan 25, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gepbird gepbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gepbird gepbird added this pull request to the merge queue Jan 25, 2026
Merged via the queue into NixOS:master with commit d7ae99d Jan 25, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gepbird gepbird gepbird approved these changes

+2 more reviewers

@qweered qweered qweered approved these changes

@penalty1083 penalty1083 penalty1083 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MCSeekeri @qweered @penalty1083 @gepbird