Skip to content

Update hydra to nix 2.30 #1502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 6, 2025
Merged

Update hydra to nix 2.30 #1502

merged 2 commits into from
Oct 6, 2025

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Aug 3, 2025

No description provided.

@Mic92 Mic92 requested a review from Ericson2314 August 3, 2025 09:41
@Mic92 Mic92 force-pushed the nix-2.30-fix branch 2 times, most recently from 5d4a756 to 190a504 Compare August 3, 2025 10:39
Ericson2314
Ericson2314 approved these changes Aug 3, 2025
View reviewed changes
Copy link
Member

@Ericson2314 Ericson2314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far, good luck with the test failure! (Can't really see what it is from my phone)

@Mic92
Copy link
Member Author

Mic92 commented Aug 4, 2025

Looking good so far, good luck with the test failure! (Can't really see what it is from my phone)

The test is failing because of the test 'nonCaDependingOnCA'.

@Ericson2314 Ericson2314 mentioned this pull request Aug 4, 2025
Merged
@Ericson2314
Copy link
Member

Ericson2314 commented Aug 5, 2025 •
edited
Loading

OK this is now down to just one commit.

@dasJ
Copy link
Member

dasJ commented Aug 5, 2025

Will take a look after https://discourse.nixos.org/t/pre-disclosure-announcement-security-advisory-for-hydra-on-august-12-2025/67615 is thorugh

@Mic92 Mic92 mentioned this pull request Aug 8, 2025
Merged
@mweinelt
Copy link
Member

Will this bite us?

NixOS/infra#764 (comment)

@Mic92
Copy link
Member Author

Mic92 commented Aug 13, 2025

Will this bite us?

NixOS/infra#764 (comment)

Yes. but this would be a problem on builders, not hydra. @xokdvium brought this up in nix team discussion. There is also https://git.lix.systems/lix-project/lix/issues/913#issuecomment-13332

@Mic92 Mic92 force-pushed the nix-2.30-fix branch 2 times, most recently from 73eaec7 to edd4d2a Compare September 22, 2025 21:14
@Mic92 Mic92 changed the title Update hydra to nix 2.30 Update hydra to nix 2.31 Sep 22, 2025
@Ericson2314 Ericson2314 changed the title Update hydra to nix 2.31 Update hydra to nix 2.30 Oct 6, 2025
@Ericson2314
Copy link
Member

Ericson2314 commented Oct 6, 2025 •
edited
Loading

OK I am just giving up on the cross compilation test for now. I don't have the energy to debug it at this time. And I hope it will just work with the new queue runner, once that is passing the test suite, also, routing around whatever regression happened here.

@Ericson2314 Ericson2314 enabled auto-merge October 6, 2025 20:20
@Ericson2314 Ericson2314 added this pull request to the merge queue Oct 6, 2025
Merged via the queue into master with commit 3059dc1 Oct 6, 2025
2 checks passed
@Ericson2314 Ericson2314 deleted the nix-2.30-fix branch October 6, 2025 20:58
@SuperSandro2000
Copy link
Member

The failing test will fail my entire hydra 😅 i cannot upgrade beyond this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ericson2314 Ericson2314 Ericson2314 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Mic92 @Ericson2314 @dasJ @mweinelt @SuperSandro2000