feat: init hydra-queue-runner-v2 #790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conni2461
force-pushed
the
feat/init-queue-runner-v2
branch
from
0e0c834 to
0239f87
Compare
Conni2461
force-pushed
the
feat/init-queue-runner-v2
branch
from
0239f87 to
6170a60
Compare
| StateDirectoryMode = "0700"; | ||
| ReadWritePaths = [ | ||
| "/nix/var/nix/gcroots/" | ||
| "/run/postgresql/.s.PGSQL.${toString config.services.postgresql.port}" |
There was a problem hiding this comment.
Will this break when postgres restarts and recreates the socket?
Conni2461
force-pushed
the
feat/init-queue-runner-v2
branch
4 times, most recently
from
5b593d9 to
4121e0e
Compare
Conni2461
force-pushed
the
feat/init-queue-runner-v2
branch
2 times, most recently
from
b779eb8 to
222c51c
Compare
|
Please run |
mweinelt
reviewed
Aug 5, 2025
Conni2461
force-pushed
the
feat/init-queue-runner-v2
branch
from
222c51c to
e21d6f5
Compare
Conni2461
commented
Aug 7, 2025
| zlib | ||
| protobuf | ||
|
|
||
| nixVersions.nix_2_29 |
There was a problem hiding this comment.
also builds and works with 2_30, but i think you are currently still using 2_29 ?
There was a problem hiding this comment.
Yeah. NixOS/hydra#1502 is currently on hold until: https://discourse.nixos.org/t/pre-disclosure-announcement-security-advisory-for-hydra-on-august-12-2025/67615
There was a problem hiding this comment.
Shouldn't this use config.nix.package?
|
found a small issue, with the ffi changes, will update asap. Edit: resolved |
Conni2461
force-pushed
the
feat/init-queue-runner-v2
branch
from
e21d6f5 to
285a237
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related pr in ofborg: ofborg/ofborg-infrastructure#14