Skip to content

Added srcset tags to product thumbnails #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
markjaniczak wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added srcset tags to product thumbnails #483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/templates/thumbs/product/box.template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
<div class="row">
<div class="col-12 col-lg-5">
<a href="[@URL@]" title="[@model@]">
<img src="[%asset_url type:'product' thumb:'thumb' id:'[@SKU@]'%][%param default%][%cdn_asset html:'0' library:'images'%]default_product.gif[%/cdn_asset%][%end param%][%/ asset_url%]" class="product-image img-fluid" width="100%" alt="[@model@]" rel="itmimg[@SKU@]">
[%set [@thumb@] %][%asset_url type:'product' thumb:'thumb' id:'[@SKU@]'%][%param default%][%cdn_asset html:'0' library:'images'%]default_product.gif[%/cdn_asset%][%end param%][%/asset_url%][%/set%]
[%set [@thumbL@] %][%asset_url type:'product' thumb:'thumbL' id:'[@SKU@]'%][%param default%][%cdn_asset html:'0' library:'images'%]default_product.gif[%/cdn_asset%][%end param%][%/asset_url%][%/set%]
<img srcset="[@thumb@] 200w, [@thumbL@] 350w, [@thumbL@] 2x" src="[@thumb@]" class="product-image img-fluid" width="100%" alt="[@model@]" rel="itmimg[@SKU@]">
</a>
[%if [@inpromo@]%]
<div class="savings-container"><span class="badge badge-danger">On Sale</span></div>
Expand Down
4 changes: 3 additions & 1 deletion src/templates/thumbs/product/list.template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@
<div class="row">
<div class="col-4 col-md-3">
<a href="[@URL@]" class="thumbnail-image">
<img src="[%asset_url type:'product' thumb:'thumb' id:'[@sku@]'%][%param default%][%cdn_asset html:'0' library:'images'%]default_product.gif[%/cdn_asset%][%/param%][%/asset_url%]" itemprop="image" class="product-image img-fluid" alt="[@model@]" rel="itmimg[@sku@]">
[%set [@thumb@] %][%asset_url type:'product' thumb:'thumb' id:'[@SKU@]'%][%param default%][%cdn_asset html:'0' library:'images'%]default_product.gif[%/cdn_asset%][%end param%][%/asset_url%][%/set%]
[%set [@thumbL@] %][%asset_url type:'product' thumb:'thumbL' id:'[@SKU@]'%][%param default%][%cdn_asset html:'0' library:'images'%]default_product.gif[%/cdn_asset%][%end param%][%/asset_url%][%/set%]
<img srcset="[@thumb@] 200w, [@thumbL@] 350w, [@thumbL@] 2x" src="[@thumb@]" itemprop="image" class="product-image img-fluid" alt="[@model@]" rel="itmimg[@sku@]">
</a>
</div>
<div class="col-8 col-md-6">
Expand Down
4 changes: 3 additions & 1 deletion src/templates/thumbs/product/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
<meta itemprop="brand" content="[@brand@]"/>
<meta itemprop="mpn" content="[@sku@]"/>
<a href="[@URL@]" class="thumbnail-image pb-2">
<img src="[%asset_url type:'product' thumb:'thumb' id:'[@SKU@]'%][%param default%][%cdn_asset html:'0' library:'images'%]default_product.gif[%/cdn_asset%][%end param%][%/asset_url%]" itemprop="image" class="product-image img-fluid" alt="[@model@]" rel="itmimg[@SKU@]">
[%set [@thumb@] %][%asset_url type:'product' thumb:'thumb' id:'[@SKU@]'%][%param default%][%cdn_asset html:'0' library:'images'%]default_product.gif[%/cdn_asset%][%end param%][%/asset_url%][%/set%]
[%set [@thumbL@] %][%asset_url type:'product' thumb:'thumbL' id:'[@SKU@]'%][%param default%][%cdn_asset html:'0' library:'images'%]default_product.gif[%/cdn_asset%][%end param%][%/asset_url%][%/set%]
<img srcset="[@thumb@] 200w, [@thumbL@] 350w, [@thumbL@] 2x" src="[@thumb@]" itemprop="image" class="product-image img-fluid" alt="[@model@]" rel="itmimg[@SKU@]">
</a>
<p class="card-title h4" itemprop="name"><a href="[@URL@]">[%format type:'text' truemaxlength:'50' rmhtml:'1'%][@model@][%/format%]</a></p>
<p class="price" itemprop="offers" itemscope itemtype="http://schema.org/Offer" aria-label="[@model@] price">
Expand Down