Added srcset tags to product thumbnails #483
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a point just beneath the xs bootstrap 4 breakpoint (<576px) where the product thumbnail images are pixelated due to being too large. The srcset tag accomodates for this point and also retina devices where the ppi is much higher (2x).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a point just beneath the xs bootstrap 4 breakpoint (<576px) where the product thumbnail images are pixelated due to being too large. The srcset tag accommodates for this point and also retina devices where the ppi is much higher (2x).
Here is a comparison on an iPhone X.
Before:
After:
The breakpoints were chosen according to the default thumbnail dimensions of 200 and 500. If a browser does not support the srcset tags, the src tag is used instead which points to the lower res image.