Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web socket updates #2409

Merged
merged 16 commits into from
Feb 6, 2025

remove func() from defer

838719f
Select commit
Loading
Failed to load commit list.
Merged

Web socket updates #2409

remove func() from defer
838719f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 6, 2025 in 1s

74.38% (target 70.00%)

View this Pull Request on Codecov

74.38% (target 70.00%)

Details

Codecov Report

Attention: Patch coverage is 71.09375% with 37 lines in your changes missing coverage. Please review.

Project coverage is 74.38%. Comparing base (daeb674) to head (838719f).

Files with missing lines Patch % Lines
rpc/subscriptions.go 60.67% 33 Missing and 2 partials ⚠️
sync/sync.go 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2409      +/-   ##
==========================================
- Coverage   74.60%   74.38%   -0.23%     
==========================================
  Files         113      113              
  Lines       13052    13136      +84     
==========================================
+ Hits         9738     9771      +33     
- Misses       2583     2627      +44     
- Partials      731      738       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.