-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web socket updates #2409
base: main
Are you sure you want to change the base?
Web socket updates #2409
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2409 +/- ##
==========================================
- Coverage 74.56% 74.31% -0.26%
==========================================
Files 113 113
Lines 13020 13038 +18
==========================================
- Hits 9709 9689 -20
- Misses 2579 2613 +34
- Partials 732 736 +4 ☔ View full report in Codecov by Sentry. |
@@ -1031,3 +1032,55 @@ func marshalSubEventsResp(e *EmittedEvent, id uint64) ([]byte, error) { | |||
}, | |||
}) | |||
} | |||
|
|||
func TestEventEquality(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was purely for debugging purposes. so it should be removed once things are fixed.
This PR introduces the most recent changes to websocket specs, please see each commit.
Todo:
blockID = pending
.