Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement getProof and verifyProof on trie #1852

Merged
merged 33 commits into from
May 13, 2024
Merged

Conversation

rianhughes
Copy link
Contributor

closes: #1851

@rianhughes rianhughes requested a review from kirugan May 1, 2024 11:26
Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 82.30769% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 75.35%. Comparing base (576d342) to head (a07d3d5).

Files Patch % Lines
core/trie/proof.go 82.24% 10 Missing and 9 partials ⚠️
core/trie/key.go 80.95% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1852      +/-   ##
==========================================
+ Coverage   75.22%   75.35%   +0.12%     
==========================================
  Files          96       97       +1     
  Lines        8183     8313     +130     
==========================================
+ Hits         6156     6264     +108     
- Misses       1506     1517      +11     
- Partials      521      532      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

core/trie/proof.go Outdated Show resolved Hide resolved
core/trie/proof.go Outdated Show resolved Hide resolved
core/trie/proof.go Outdated Show resolved Hide resolved
core/trie/proof.go Outdated Show resolved Hide resolved
core/trie/proof.go Outdated Show resolved Hide resolved
@rianhughes rianhughes requested a review from kirugan May 2, 2024 12:28
@rianhughes rianhughes force-pushed the rianhughes/trie-proof2 branch from 57ee60c to 53753d1 Compare May 3, 2024 14:17
core/trie/proof.go Outdated Show resolved Hide resolved
@rianhughes rianhughes force-pushed the rianhughes/trie-proof2 branch from d242797 to c343913 Compare May 7, 2024 09:05
@rianhughes rianhughes requested a review from asdacap May 8, 2024 13:50
Copy link
Contributor

@asdacap asdacap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the proving need to work for range also instead of just one leaf (can be done later), looks good to me.

core/trie/proof.go Outdated Show resolved Hide resolved
@rianhughes rianhughes merged commit 264eb96 into main May 13, 2024
10 checks passed
@rianhughes rianhughes deleted the rianhughes/trie-proof2 branch May 13, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

implement getProof and verifyProof on trie
3 participants