comment

Author: rian

core/trie/proof.go

@@ -21,7 +21,7 @@ func (pn *ProofNode) Hash() *felt.Felt {
 		return crypto.Pedersen(pn.Binary.LeftHash, pn.Binary.RightHash)
 	case pn.Edge != nil:
 		length := make([]byte, len(pn.Edge.Path.bitset))
-		length[31] = pn.Edge.Path.len
+		length[len(pn.Edge.Path.bitset)-1] = pn.Edge.Path.len
 		pathFelt := pn.Edge.Path.Felt()
 		lengthFelt := new(felt.Felt).SetBytes(length)
 		return new(felt.Felt).Add(crypto.Pedersen(pn.Edge.Child, &pathFelt), lengthFelt)
@@ -55,7 +55,6 @@ type Edge struct {
 	Value *felt.Felt
 }
 
-// Edge nodes are defined as having a child with len greater than 1 from the parent
 func isEdge(sNode storageNode, nodeNumFromRoot int) bool {
 	sNodeLen := sNode.key.len
 	leftKey := sNode.node.Left.len
@@ -69,6 +68,8 @@ func isEdge(sNode storageNode, nodeNumFromRoot int) bool {
 	return false
 }
 
+// The binary node uses the hash of children. If the child is an edge, we first need to represent it
+// as an edge node, and then take its hash.
 func getChildHash(tri *Trie, sNode storageNode, childKey *Key, nodeNumFromRoot int) (*felt.Felt, error) {
 	childNode, err := tri.GetNodeFromKey(childKey)
 	if err != nil {
@@ -105,8 +106,7 @@ func GetProof(leaf *felt.Felt, tri *Trie) ([]ProofNode, error) {
 	// -> Child should be leaf (len=251). Distance between child and parent should be > 1.
 
 	for i, sNode := range nodesExcludingLeaf {
-		// The binary node uses the hash of children. If the child is an edge, we represent it
-		// as an edge, and then take its hash.
+
 		leftHash, err := getChildHash(tri, sNode, sNode.node.Left, i)
 		if err != nil {
 			return nil, err