Fix docstring inclusion of is_square
#2197
Merged
+9
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
reviewed
Dec 11, 2025
| ```@docs | ||
| is_square(::ZZRingElem) | ||
| ```@docs; canonical=false | ||
| is_square(::NCRingElement) |
Member
There was a problem hiding this comment.
I am OK with merging this as a "quick fix" but I wonder if we should not instead do it similar to how we did it in AA, and just have a list here:
The following standard ring methods are implemented for `ZZRingElem`:
- [`is_square`](@ref)
- ...possibly followed by an example?
Member
Author
There was a problem hiding this comment.
I agree that this is not optimal right now, but I just wanted to do a mechanical change as a bandaid
fingolfin
approved these changes
Dec 11, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2197 +/- ##
==========================================
- Coverage 88.24% 88.22% -0.03%
==========================================
Files 99 99
Lines 37056 37056
==========================================
- Hits 32701 32691 -10
- Misses 4355 4365 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (together with Nemocas/AbstractAlgebra.jl#2242) fixes building the Nemo docs, at least it does so locally for me.