-
Notifications
You must be signed in to change notification settings - Fork 164
Ag/selfprojecting matroids #5558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AlheydisGeiger
wants to merge
102
commits into
oscar-system:master
Choose a base branch
from
AlheydisGeiger:ag/selfprojecting_matroids
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ag/selfprojecting matroids #5558
AlheydisGeiger
wants to merge
102
commits into
oscar-system:master
from
AlheydisGeiger:ag/selfprojecting_matroids
+994
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith a first attempt at struct and some first functions, still problems with the computation of the selfprojecting realization ideal
…jecting matrix does not yet work
…alization spaces, also added a .jl file that contains the first steps towards a struct that can be used in the pending database collection
…to ag/selfprojecting_matroids
…the selfprojecting realization matrix works
…ications in the MRS and SPMRS files
…realizations instead of the classical realizations, and adjusted the function computing the self-projecting realization space for the case that this space is empty.
… the inequations to avoid repetitions and 1, products are not excluded so far.
…to ag/selfprojecting_matroids
…QQ the coefficient ring cannot be computed
…ypes of some properties to allow for the case when the computation for the selfprojecting realization space did not terminate
Provide extra method for underlying_scheme.
…ojecting realization matrix
Co-authored-by: antonydellavecchia <[email protected]>
… to be better readable
Co-authored-by: antonydellavecchia <[email protected]>
Co-authored-by: antonydellavecchia <[email protected]>
Co-authored-by: antonydellavecchia <[email protected]>
…n of MatroidRealizationSpaces.jl
Co-authored-by: antonydellavecchia <[email protected]>
Co-authored-by: antonydellavecchia <[email protected]>
Co-authored-by: antonydellavecchia <[email protected]>
Co-authored-by: antonydellavecchia <[email protected]>
…mputation of the selfprojecting realization ideal
Member
|
The current documentation build failure is not your fault. It will be fixed by Nemocas/Nemo.jl#2197 soon-ish |
lgoettgens
reviewed
Dec 11, 2025
lgoettgens
reviewed
Dec 11, 2025
lgoettgens
reviewed
Dec 11, 2025
|
|
||
| julia> selfprojecting_realization_ideal(m) | ||
| ┌ Warning: This function is slow except for small matroids! | ||
| └ @ Oscar ~/Documents/Oscar.jl/experimental/MatroidRealizationSpaces/src/SelfProjectingMatroids.jl:169 |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these warnings are causing issues in the doctests.
I think you should avoid warnings here and add a warning in the regular part of the docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code accompanies the article "The self-projecting Grassmannian" with Francesca Zaffalon, planned to be on arXiv by the end of the month. There will also be a database collection for oscarDB.
There are a few things that do not work yet in the functions to compute the selfprojecting_realization_matrix and selfprojecting_realization_ideal, or rather that cannot be tested, because the code doesn't terminate for relevant examples.
Questions and comments are welcome.
Tests and documentations are not yet done. I have never written tests for Oscar before, so I'd appreciate some help/advice/pointers.