Skip to content

Fix incorrect PyBind11 headers target reference #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanmrichard merged 2 commits into from
Jun 9, 2025
Merged

Fix incorrect PyBind11 headers target reference #365

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
586439b
Fix incorrect PyBind11 headers target reference
Jun 9, 2025
2888629
Add more explanation to incomplete PyBind11 import explanation (and r…
Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,14 @@ cmaize_find_optional_dependency(
set(pluginplay_depends utilities parallelzone libfort Boost::boost RocksDB)

# As of 1.0.0 CMaize does not support multiple build or find targets. This will
# be fixed in a future feature release. For now we handle the
# be fixed in a future feature release. For now we handle the exposed CMake
# targets separately instead of a CMaize target
include(nwx_pybind11)
if("${BUILD_PYBIND11_PYBINDINGS}")
nwx_find_pybind11()
list(
APPEND pluginplay_depends
pybind11_headers pybind11::embed Python::Python
pybind11::headers pybind11::embed Python::Python
)
endif()

Expand Down