Fix incorrect PyBind11 headers target reference #365
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this pull request associated with an issue(s)?
No.
Description
The current name used to reference the PyBind11 headers target (
pybind11_headers) only exists if PyBind11 is built with your project. If it is already installed, the exported target is insteadpybind11::headers. During the build,pybind11_headersis aliased topybind11::headers(here), so usingpybind11::headersexclusively should work in both scenarios.TODOs