Skip to content

Fix gather index type in ann_ivf_flat test #2279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huuanhhuyn wants to merge 3 commits into
base: main
Choose a base branch
from
+5 −5
Open

Fix gather index type in ann_ivf_flat test #2279

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2db9d3d
Fix gather index type in ann_ivf_flat test
huuanhhuyn Jun 30, 2026
95e5f42
Change flat_codes index type to int
huuanhhuyn Jun 30, 2026
fea04e8
Merge branch 'main' into fix_index_type_ivf_flat
huuanhhuyn Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions cpp/tests/neighbors/ann_ivf_flat.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,14 +307,14 @@ class AnnIVFFlatTest : public ::testing::TestWithParam<AnnIvfFlatInputs<IdxT>> {
auto& list_inds = extend_index.lists()[label]->indices;

// fetch the flat codes
auto flat_codes = raft::make_device_matrix<DataT, uint32_t>(handle_, list_size, idx.dim());
auto flat_codes = raft::make_device_matrix<DataT, int32_t>(handle_, list_size, idx.dim());

raft::matrix::gather(
handle_,
raft::make_device_matrix_view<const DataT, uint32_t>(
(const DataT*)database.data(), static_cast<uint32_t>(ps.num_db_vecs), idx.dim()),
raft::make_device_vector_view<const IdxT, uint32_t>((const IdxT*)list_inds.data_handle(),
list_size),
raft::make_device_matrix_view<const DataT, int32_t>(

@huuanhhuyn huuanhhuyn Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change fixes this.
I don't get why FastIntDiv is resolved by this gather. Shouldn't FastIntDiv only be used by in-place gather.

(const DataT*)database.data(), static_cast<int32_t>(ps.num_db_vecs), idx.dim()),
raft::make_device_vector_view<const IdxT, int32_t>((const IdxT*)list_inds.data_handle(),
list_size),
flat_codes.view());

helpers::codepacker::pack(
Expand Down
Loading