Fix gather index type in ann_ivf_flat test#2279
Open
huuanhhuyn wants to merge 3 commits into
Open
Conversation
huuanhhuyn
changed the title
huuanhhuyn
changed the title
huuanhhuyn
commented
Jun 30, 2026
| (const DataT*)database.data(), static_cast<uint32_t>(ps.num_db_vecs), idx.dim()), | ||
| raft::make_device_vector_view<const IdxT, uint32_t>((const IdxT*)list_inds.data_handle(), | ||
| list_size), | ||
| raft::make_device_matrix_view<const DataT, int32_t>( |
Author
There was a problem hiding this comment.
the change fixes this.
I don't get why FastIntDiv is resolved by this gather. Shouldn't FastIntDiv only be used by in-place gather.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change gather index type to int32_t.
Follow up to NVIDIA/raft#3059.