Add Spark 3.5 and 4.0 SQL shim module sources#15042
Conversation
0c5a1fb to
ac60c19
Compare
Signed-off-by: Gera Shegalov <gshegalov@nvidia.com>
Signed-off-by: Gera Shegalov <gshegalov@nvidia.com>
ac60c19 to
8288b83
Compare
Greptile SummaryThis PR populates the new
Confidence Score: 4/5Safe to merge — all 21 files are faithful copies of pre-existing sql-plugin sources with no behavioral changes introduced. Every added file was verified against its sql-plugin original and matches character-for-character (modulo copyright year). The one flagged item — the misleading sql-plugin-shims/src/main/spark350db143/scala/com/nvidia/spark/rapids/shims/spark350db143/SparkShimServiceProvider.scala — the Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
subgraph sql-plugin-shims ["sql-plugin-shims (new module)"]
SP350[spark350 SparkShimServiceProvider] --> SV350[SparkShimVersion 3.5.0]
SP351[spark351] --> SV351[SparkShimVersion 3.5.1 + SNAPSHOT]
SP352[spark352..358] --> SV35x[SparkShimVersion 3.5.x]
SP400[spark400] --> SV400[SparkShimVersion 4.0.0]
SP401[spark401..402] --> SV40x[SparkShimVersion 4.0.x]
SP411[spark411] --> SV411[SparkShimVersion 4.1.1]
SP350DB[spark350db143 SparkShimServiceProvider] --> DBV143[DatabricksShimVersion 3.5.0 / 14.3]
SP400DB[spark400db173 SparkShimServiceProvider] --> DBV173[DatabricksShimVersion 4.0.0 / 17.3]
end
SP350DB -->|runtime check: dbrVersion startsWith 14.3.x| DBV143
SP400DB -->|runtime check: dbrVersion startsWith 17.3.x| DBV173
sql-plugin-shims -->|exact copy of sources| existing["sql-plugin/src/main/spark{VERSION}"]
Reviews (1): Last reviewed commit: "Add SQL shim module sources for Spark 4" | Re-trigger Greptile |
Related to #14834.
Description
This PR is one reviewable layer in the unshim stack introduced by #15025. It adds the Spark 3.5 and Spark 4.0 SQL shim module sources as the final source-population layer before columnar/helper class movement begins.
Stack context
Testing and validation notes
Checklists
Documentation
Testing
(Covered by the validation notes in the PR description.)
Performance