Add Spark 3.3.1 through 3.4 SQL shim module sources#15041
Conversation
b311578 to
de49e32
Compare
eb7407b to
80a2612
Compare
Signed-off-by: Gera Shegalov <gshegalov@nvidia.com>
de49e32 to
e6f5a41
Compare
80a2612 to
271c29e
Compare
Greptile SummaryThis PR is one layer in the "unshim stack" restructuring (#15025) that splits shim sources out of
Confidence Score: 5/5All 17 files are mechanical copies of existing sql-plugin sources into the new sql-plugin-shims module with no logic changes; safe to merge as part of the unshim stack sequence. Every added file is a verbatim copy of its counterpart already shipping in sql-plugin, validated by the author as tree-equivalent at the full-stack level. The shim json-lines annotations, version constants, and DB delegation patterns all match the established conventions in the codebase. No resource management, GPU operations, or data-path logic is touched. No files require special attention. The multi-version shim files in spark332db (SparkUpgradeExceptionShims, CreateDataSourceTableAsSelectRules, WriteFilesExecShims) have the widest applicability (332db → 411) and are the most worth spot-checking against the sql-plugin originals, which they match exactly. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[sql-plugin-shims module] --> B[spark331 / spark332 / spark333 / spark334]
A --> C[spark332db]
A --> D[spark340 / spark341 / spark341db]
A --> E[spark342 / spark343 / spark344]
B --> B1[SparkShimServiceProvider\nSparkShimVersion 3.3.x]
C --> C1[SparkShimServiceProvider\nDatabricksShimVersion 3.3.2 DB12.2]
C --> C2[CreateDataSourceTableAsSelectRules\nmulti-version: 332db to 411]
C --> C3[WriteFilesExecShims\nmulti-version: 332db to 411]
C --> C4[SparkDateTimeExceptionShims\nmulti-version: 332db to 411]
C --> C5[SparkUpgradeExceptionShims\nmulti-version: 332db to 411]
D --> D1[SparkShimServiceProvider\nSparkShimVersion 3.4.0/3.4.1\nor DatabricksShimVersion DB13.3]
D --> D2[OriginContextShim\nmulti-version: 340 to 358\nSQLQueryContext typed]
E --> E1[SparkShimServiceProvider\nSparkShimVersion 3.4.2-3.4.4]
B1 -.->|also covers via spark334| F[SequenceSizeTooLongUnsuccessfulErrorBuilder\n334 / 342-344 / 351-358]
E1 -.-> F
Reviews (1): Last reviewed commit: "Add SQL shim module sources for Spark 3...." | Re-trigger Greptile |
Related to #14834.
Description
This PR is one reviewable layer in the unshim stack introduced by #15025. It adds the Spark 3.3.1 through Spark 3.4 SQL shim module sources as a focused shim-family source population step.
Stack context
Testing and validation notes
Checklists
Documentation
Testing
(Covered by the validation notes in the PR description.)
Performance