Skip to content

Fuse permute+pad and unpermute+unpad ops for FP8/FP4 training #2763

Merged
yaox12 merged 14 commits into
NVIDIA:mainfrom
021ai:fused_perm_pad
Feb 7, 2026
Merged

Fuse permute+pad and unpermute+unpad ops for FP8/FP4 training #2763
yaox12 merged 14 commits into
NVIDIA:mainfrom
021ai:fused_perm_pad

Conversation

@xiaoxi-wangfj

Copy link
Copy Markdown
Contributor

What does this PR do ?

Integrate TransformerEngine fused MoE permute+pad and unpermute+unpad FP8 fast-path (NVIDIA/TransformerEngine#1921) into Megatron-LM MoE token dispatching, eliminating explicit padding/unpadding steps in the experts path to improve performance and reduce peak GPU memory usage.

Background / Motivation

TransformerEngine PR NVIDIA/TransformerEngine#1921 introduces:

  • moe_permute_and_pad_with_probs (fused moe_permute_with_probs + Fp8Padding)
  • extended moe_unpermute(..., pad_offsets=...) (fused moe_unpermute + Fp8Unpadding)

These TE-side fused kernels require Megatron-LM changes to:

  • pass tokens_per_expert and FP8 alignment size into permute
  • carry pad_offsets through dispatch and feed it back into unpermute
  • gate the new path behind a configuration switch / availability checks

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@xiaoxi-wangfj xiaoxi-wangfj requested review from a team as code owners December 26, 2025 07:05
@copy-pr-bot

copy-pr-bot Bot commented Dec 26, 2025

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@xiaoxi-wangfj

Copy link
Copy Markdown
Contributor Author

@yaox12 This PR integrates support for the fused permute+pad and unpermute+unpad APIs in Megatron-LM. Appreciate your review.

This can remove explicit padding/unpadding around GroupedMLP,
which improves throughput and reduces peak memory usage

Signed-off-by: xiaoxi-wangfj <690912414@qq.com>
Comment thread megatron/training/arguments.py Outdated
@yanring yanring requested a review from yaox12 January 4, 2026 07:38
@yaox12 yaox12 added the Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. label Jan 4, 2026
Comment thread megatron/core/transformer/moe/moe_utils.py Outdated
Comment thread megatron/core/transformer/moe/moe_utils.py
Comment thread megatron/core/transformer/moe/moe_utils.py Outdated
Comment thread megatron/core/transformer/transformer_config.py Outdated
Comment thread megatron/training/arguments.py Outdated
Signed-off-by: xiaoxi-wangfj <690912414@qq.com>
@xiaoxi-wangfj

Copy link
Copy Markdown
Contributor Author

Hi @yaox12
The moe-permute-padding-for-quantization flag has been removed.
The system now defaults to fused_permute_and_pad_with_probs.
When this kernel is not available (e.g., due to TE version constraints),
it transparently falls back to fused_permute_with_probs + FP8 padding.

@yaox12

yaox12 commented Jan 9, 2026

Copy link
Copy Markdown
Member

Hi @yaox12 The moe-permute-padding-for-quantization flag has been removed. The system now defaults to fused_permute_and_pad_with_probs. When this kernel is not available (e.g., due to TE version constraints), it transparently falls back to fused_permute_with_probs + FP8 padding.

Thanks. I'll review it later.

@yaox12

yaox12 commented Feb 4, 2026

Copy link
Copy Markdown
Member

/ok to test 911548e

@yaox12

yaox12 commented Feb 5, 2026

Copy link
Copy Markdown
Member

/ok to test ea197bc

@yaox12 yaox12 added this pull request to the merge queue Feb 6, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Feb 6, 2026
@yaox12 yaox12 added this pull request to the merge queue Feb 6, 2026
github-merge-queue Bot pushed a commit that referenced this pull request Feb 6, 2026
Signed-off-by: xiaoxi-wangfj <690912414@qq.com>
Co-authored-by: Xin Yao <xiny@nvidia.com>
github-merge-queue Bot pushed a commit that referenced this pull request Feb 6, 2026
Signed-off-by: xiaoxi-wangfj <690912414@qq.com>
Co-authored-by: Xin Yao <xiny@nvidia.com>
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Feb 6, 2026
@yaox12 yaox12 added this pull request to the merge queue Feb 6, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Feb 6, 2026
@yaox12 yaox12 added this pull request to the merge queue Feb 7, 2026
Merged via the queue into NVIDIA:main with commit 554ce49 Feb 7, 2026
70 of 73 checks passed
@yaox12 yaox12 deleted the fused_perm_pad branch February 7, 2026 16:06
daiyaanarfeen pushed a commit to daiyaanarfeen/Megatron-LM that referenced this pull request Feb 23, 2026
…#2763)

Signed-off-by: xiaoxi-wangfj <690912414@qq.com>
Co-authored-by: Xin Yao <xiny@nvidia.com>
BoxiangW pushed a commit to BoxiangW/Megatron-LM that referenced this pull request Mar 4, 2026
…#2763)

Signed-off-by: xiaoxi-wangfj <690912414@qq.com>
Co-authored-by: Xin Yao <xiny@nvidia.com>
yangbofun pushed a commit to xlm-research/Megatron-LM that referenced this pull request May 22, 2026
…#2763)

Signed-off-by: xiaoxi-wangfj <690912414@qq.com>
Co-authored-by: Xin Yao <xiny@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-request Final Review PR is in the "final review" stage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants