[MoE]Enable Casting-Free FP8-Flow-MoE Blockwise FP8 Dataflow#2764
Open
xiaoxi-wangfj wants to merge 7 commits into
Open
[MoE]Enable Casting-Free FP8-Flow-MoE Blockwise FP8 Dataflow#2764xiaoxi-wangfj wants to merge 7 commits into
xiaoxi-wangfj wants to merge 7 commits into
Conversation
13 tasks
Member
|
Can you please add tests for the new features? |
1. Quantize activations to FP8 before deepep token dispatch. 2. Feed FP8 activations directly into expert up-projection. 3. Fusion act func and quantize. 4. Add fine-grained recompute `moe_expert`. Signed-off-by: xiaoxi-wangfj <690912414@qq.com> Co-authored-by: dantesuu@gmail.com Co-authored-by: xzhu@zhejianglab.org Co-authored-by: 123sssmmm@gmail.com
1. Quantize activations to FP8 before deepep token dispatch. 2. Feed FP8 activations directly into expert up-projection. 3. Fusion act func and quantize. 4. Add fine-grained recompute `moe_expert`. Signed-off-by: xiaoxi-wangfj <690912414@qq.com> Co-authored-by: dantesuu@gmail.com Co-authored-by: xzhu@zhejianglab.org Co-authored-by: 123sssmmm@gmail.com
468d4b3 to
cd4b686
Compare
Signed-off-by: xiaoxi.wangfj <690912414@qq.com>
Signed-off-by: xiaoxi.wangfj <690912414@qq.com>
Signed-off-by: xiaoxi.wangfj <690912414@qq.com>
Signed-off-by: xiaoxi.wangfj <690912414@qq.com>
Contributor
Author
|
@Phlip79 tests are added. |
Member
|
/claude review |
Contributor
There was a problem hiding this comment.
Two small issues flagged inline:
-
Bug in
FusedCombine.forward(fused_a2a.py:201-202):ctx.fp8_recipe = config.fp8_recipewill crash whenconfig is None— the preceding line correctly guards against this but this one doesn't. -
Typo in error message (
transformer_config.py:1436):"moe_expert recompute_modules is supported fp8 blockwise recipe"is missing "only" and "with".
Member
|
/ok to test 2dfcf5c |
Signed-off-by: xiaoxi.wangfj <690912414@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR introduces a set of FP8-centric MoE dataflow optimizations that improve FP8 communication performance and reduce CPU overhead through operator fusion, while maintaining numerical stability in existing FP8 training workflows.
This PR is designed to be used in conjunction with PR NVIDIA/TransformerEngine#2544
Further optimizations are introduced via two additional PRs:
Background / Motivation
Detailed optimization points are described in the joint PR NVIDIA/TransformerEngine#2544
Contribution process
flowchart LR A[Pre-checks] --> B[PR Tests] subgraph Code Review/Approval C1[Expert Review] --> C2[Final Review] end B --> C1 C2 --> D[Merge]Pre-checks
Core 0.8)Code review
The following process is enforced via the CODEOWNERS file for changes into
megatron/core. For changes outside ofmegatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.For MRs into `main` branch
(Step 1): Add PR label
Expert Review(Step 2): Collect the expert reviewers reviews
Expert Reviewlabel when your PR is ready for review.Final Review might get declined if these requirements are not fulfilled.
(Step 3): Final Review
Final Reviewlabel(Optional Step 4): Cherry-pick into release branch
If this PR also needs to be merged into
core_r*release branches, after this PR has been merged, selectCherry-pickto open a new PR into the release branch.For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.Merging your PR
Any member of core-adlr and
core-nemowill be able to merge your PR.