Fix MC HIP-RA test #178
Merged
Fix MC HIP-RA test #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y specifying in request rather than settings file
malcolm-dsider
approved these changes
Apr 4, 2024
|
Thanks for approving @malcolm-dsider! Merged and created follow-up issue per description: #179 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #151
Note: test was broken due to relative output path issue; this issue is still present if output file is passed in settings file (rather than
MonteCarloRequest) - added FIXME in https://github.com/NREL/GEOPHIRES-X/pull/178/files#diff-d6aa9193390bfa4a8a702d91c930ef178551f54dfbbd5bbaf785c467d7e28800R462-R463, will create separate tracking issue for this since MC itself is 'fixed' by this PR in terms of having a passing test for reference