Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MC Settings Output File relative path issue #179

Open
softwareengineerprogrammer opened this issue Apr 4, 2024 · 0 comments
Open

MC Settings Output File relative path issue #179

softwareengineerprogrammer opened this issue Apr 4, 2024 · 0 comments
Assignees
@softwareengineerprogrammer
Labels
bug Something isn't working

Comments

@softwareengineerprogrammer
Copy link
Collaborator

MC needs to ensure relative paths read in from settings file are correct, as mentioned in #178 and marked with FIXME:

GEOPHIRES-X/src/geophires_monte_carlo/MC_GeoPHIRES3.py

Lines 462 to 463 in 215a372

# FIXME accepting relative paths here is likely to break MC, consolidate/align setting output file with
# pattern in geophires_monte_carlo.MonteCarloRequest

@softwareengineerprogrammer softwareengineerprogrammer added the bug Something isn't working label Apr 4, 2024
Merged
@softwareengineerprogrammer softwareengineerprogrammer changed the title MC Settings Output File path issues MC Settings Output File relative path issue Apr 4, 2024
softwareengineerprogrammer referenced this issue in softwareengineerprogrammer/GEOPHIRES Apr 11, 2024
@softwareengineerprogrammer
FIXME re: output file relative path landmine
ca4a004
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@softwareengineerprogrammer softwareengineerprogrammer

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@softwareengineerprogrammer