Update pyFV3 and pySHiELD submodules #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 13, 2026
romanc
force-pushed
the
romanc/update-pyfv3-pyshield-pre-2026.01.00
branch
from
41c69b1 to
c09acb6
Compare
This was referenced Jan 14, 2026
romanc
force-pushed
the
romanc/update-pyfv3-pyshield-pre-2026.01.00
branch
from
59054e4 to
71c82d1
Compare
This PR updates pyFV3 and pySHiELD submodules in pace to include the latest changes. These changes are necessary to fully remove deprecated code in NDSL (which is planned for the upcoming 2026.01.00 release). We are also temporarily skipping `mypy` checking for `translate_fvdynamics.py`. There are type issue in the translate test system which we will address in the next release of NDSL. Once we update pyFV3 to NDSL version 2026.01.00, we should be able to remove that exception again. For context see NOAA-GFDL/NDSL#360.
romanc
force-pushed
the
romanc/update-pyfv3-pyshield-pre-2026.01.00
branch
from
71c82d1 to
4851077
Compare
fmalatino
approved these changes
Jan 16, 2026
jjuyeonkim
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates pyFV3 and pySHiELD submodules in pace to include the latest changes. These changes are necessary to fully remove deprecated code in NDSL (which is planned for the upcoming 2026.01.00 release). This is currently blocking
NullCommNDSL#350QuanityFactory.from_backend()NDSL#356Quantity&QuantityMetadatachanges NDSL#357This PR depend on the following changes in PyFV3 and PySHiELD
which are both merged by now. The
mypyexception for the fvdynamics translate test can be removed with the update (of pace) to NDSL 2026.01.00.How Has This Been Tested?
All good as long as CI is still green.
Checklist: