Skip to content

BREAKING CHANGE: Quantity & QuantityMetadata changes #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
romanc merged 4 commits into from
Jan 16, 2026
Merged

BREAKING CHANGE: Quantity & QuantityMetadata changes #357

romanc merged 4 commits into from
Jan 16, 2026

Conversation

@romanc
Copy link
Collaborator

@romanc romanc commented Jan 8, 2026 •
edited
Loading

Description

Remove deprecation from Quatnity and QuantityMetadata. This includes

  • gt4py_backend is superseded by just backend
  • the backend argument/member is required now
  • data must be allocated by either numpy or cupy

Blocked by NOAA-GFDL/pace#173

How has this been tested?

All good as long as CI is still happy.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas: N/A
  • I have made corresponding changes to the documentation (e.g. add new modules to docs/docstrings/)
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included: N/A

This was referenced Jan 13, 2026
Merged
Merged
Merged
romanc added 4 commits January 16, 2026 15:40
@romanc
BREAKING CHANGE: Quantity & QuantityMetadata changes
2bcd827 
Remove deprecation from `Quanity` and `QuantityMetadata`. This includes

- `gt4py_backend` is superseded by just `backend`
- the `backend` argument/member is required now
- data must be allocated by either numpy or cupy
@romanc
remove unused function
3951ea7 
I've checked (GH search) the NOAA-GFDL org and nothing and nowhere else
in that organization is the (string) name of this function found.
@romanc
fixup: supply backend in parallel translate tests
956cd46
@romanc
fixup: fix test (no need to test backend=None anymore)
e701ac5
@romanc romanc force-pushed the romanc/remove-quantity-gt4py-backend branch from 1d8cb04 to e701ac5 Compare January 16, 2026 14:41
@romanc romanc marked this pull request as ready for review January 16, 2026 14:43
FlorianDeconinck
FlorianDeconinck approved these changes Jan 16, 2026
View reviewed changes
Copy link
Collaborator

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@romanc romanc enabled auto-merge January 16, 2026 14:53
@romanc romanc added this pull request to the merge queue Jan 16, 2026
Merged via the queue into NOAA-GFDL:develop with commit 698de25 Jan 16, 2026
6 checks passed
@romanc romanc deleted the romanc/remove-quantity-gt4py-backend branch January 16, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FlorianDeconinck FlorianDeconinck FlorianDeconinck approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@romanc @FlorianDeconinck