Skip to content

Conversation

@romanc
Copy link
Collaborator

@romanc romanc commented Aug 13, 2025

Description

Using merge queues was talked about in the pace meeting in August. No concerns were raised and we've successfully adopted merge queues in NDSL with NOAA-GFDL/NDSL#194.

This PR configures pace tests to not only run on pull requests, but also in the merge queue. @fmalatino would you help me again as repo admin to do the repo configuration? Should be one-to-one from what we did in NDSL.

How Has This Been Tested?

Similar to what we have configured in NDSL. The new behavior will be apparent once we merge. I'll keep an eye out of oddities for the first couple PRs that get merged with the merge queue.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation: N/A
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules: N/A
  • New check tests, if applicable, are included

@romanc romanc marked this pull request as ready for review August 13, 2025 20:21
@romanc romanc requested a review from fmalatino August 13, 2025 20:22
@fmalatino fmalatino added this pull request to the merge queue Aug 14, 2025
Merged via the queue into NOAA-GFDL:develop with commit 5f5016e Aug 14, 2025
2 checks passed
@romanc romanc deleted the romanc/merge-queue branch August 14, 2025 15:05
@romanc romanc mentioned this pull request Aug 14, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants