Skip to content

Conversation

@romanc
Copy link
Collaborator

@romanc romanc commented Aug 14, 2025

Description

A small follow-up from PR #133. I somehow missed that - sorry!

Currently, "pace main unit tests" run on push to any branch. In case of develop, this is redundant with the merge queue checks. In case of any branch that isn't protected (e.g. anything that is not the main branch), running ci isn't necessary. This is consistent with the linting workflow and other workflow configurations (e.g. PyFV3 and PySHiELD).

How Has This Been Tested?

Self-review of code. This is copied from other (working) workflows.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation: N/A
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules: N/A
  • New check tests, if applicable, are included: N/A

Currently, "pace main unit tests" run on push to any branch. In case of
`develop`, this is redundant with the merge queue checks. In case of any
branch that isn't protected (e.g. isn't the main branch), running ci
isn't necessary. This is consistent with the linting workflow and other
workflow configurations (e.g. PyFV3 and PySHiELD).
@romanc romanc requested a review from fmalatino August 14, 2025 15:23
@romanc
Copy link
Collaborator Author

romanc commented Aug 20, 2025

ping @fmalatino: friendly reminder 😉

@romanc
Copy link
Collaborator Author

romanc commented Aug 20, 2025

FYI: I don't have rights to merge in the pace repo.

@fmalatino fmalatino added this pull request to the merge queue Aug 20, 2025
Merged via the queue into NOAA-GFDL:develop with commit d0444dd Aug 20, 2025
2 checks passed
@romanc romanc deleted the romanc/ci-only-on-push-to-main branch August 22, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants