Skip to content

Conversation

@fmalatino
Copy link
Contributor

Description
This PR updates our GitHub workflows to use actions/checkout@v6, actions/setup-python@v6, and actions/cache@v5. Changes are minimal, but require a new minimal GHA runner version, which forces the major version bumps.

How Has This Been Tested?
Using currently implemented CI

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • Targeted model if this changed was triggered by a model need/shortcoming

Copy link
Collaborator

@romanc romanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Question: why is this PR (still) a draft?

Regarding the GHA caches: GitHub will delete cache entries that haven't been accessed within 7 days and we only ever create caches upon merging into develop. So I guess we lost caches over the holidays.

@fmalatino fmalatino marked this pull request as ready for review January 9, 2026 14:35
@fmalatino
Copy link
Contributor Author

LGTM 👍

Question: why is this PR (still) a draft?

Regarding the GHA caches: GitHub will delete cache entries that haven't been accessed within 7 days and we only ever create caches upon merging into develop. So I guess we lost caches over the holidays.

I am not sure if it is good practice, but I thought I would keep it in draft until I was sure the tests pass.

@romanc
Copy link
Collaborator

romanc commented Jan 9, 2026

Question: why is this PR (still) a draft?

I am not sure if it is good practice, but I thought I would keep it in draft until I was sure the tests pass.

For me, "draft PR" signals "not ready for review" unless explicitly requested (e.g. in scenarios where one would reach out for early feedback). This matches GitHub lingo, which would show a button "Ready for review" on draft PRs. This PR seemed done and "ready for review".

@fmalatino
Copy link
Contributor Author

Since we have not had a merge into develop in about 2 months, and as noted by @romanc, caches are only created on such merges, if agreed upon by all reviewers, I suggest we merge this PR with the two failing translate tests given that the changes brought in will not effect the functionality of the code.

@romanc
Copy link
Collaborator

romanc commented Jan 9, 2026

Since we have not had a merge into develop in about 2 months, and as noted by @romanc, caches are only created on such merges, if agreed upon by all reviewers, I suggest we merge this PR with the two failing translate tests given that the changes brought in will not effect the functionality of the code.

+1 for merging this with admin powers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants