Skip to content

Fix bug in registration of ALE sponge diagnostics for generic tracers #1003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hallberg-NOAA merged 3 commits into from
Dec 26, 2025
Merged

Fix bug in registration of ALE sponge diagnostics for generic tracers #1003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
291d15a
Init all sponge tendency diag IDs to -1 immediately
andrew-c-ross Dec 4, 2025
cfd434b
No need to reset to -1 since initialized when declared
andrew-c-ross Dec 4, 2025
f789c31
Move init_ALE_sponge_diags to after all tracers have been set up
andrew-c-ross Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/core/MOM.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3602,13 +3602,9 @@ subroutine initialize_MOM(Time, Time_init, param_file, dirs, CS, &
if (associated(CS%sponge_CSp)) &
call init_sponge_diags(Time, G, GV, US, diag, CS%sponge_CSp)

if (associated(CS%ALE_sponge_CSp)) &
call init_ALE_sponge_diags(Time, G, diag, CS%ALE_sponge_CSp, US)

if (associated(CS%oda_incupd_CSp)) &
call init_oda_incupd_diags(Time, G, GV, diag, CS%oda_incupd_CSp, US)


call tracer_advect_init(Time, G, US, param_file, diag, CS%tracer_adv_CSp)
call tracer_hor_diff_init(Time, G, GV, US, param_file, diag, CS%tv%eqn_of_state, CS%diabatic_CSp, &
CS%tracer_diff_CSp)
Expand Down Expand Up @@ -3642,6 +3638,9 @@ subroutine initialize_MOM(Time, Time_init, param_file, dirs, CS, &
CS%ALE_sponge_CSp, CS%tv)
if (present(tracer_flow_CSp)) tracer_flow_CSp => CS%tracer_flow_CSp

if (associated(CS%ALE_sponge_CSp)) &
call init_ALE_sponge_diags(Time, G, diag, CS%ALE_sponge_CSp, US)

! If running in offline tracer mode, initialize the necessary control structure and
! parameters
if (present(offline_tracer_mode)) offline_tracer_mode=CS%offline_tracer_mode
Expand Down
6 changes: 3 additions & 3 deletions src/parameterizations/vertical/MOM_ALE_sponge.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,8 +142,9 @@ module MOM_ALE_sponge
!! It is not clear why this needs to be greater than 0.

!>@{ Diagnostic IDs
integer, dimension(MAX_FIELDS_) :: id_sp_tendency !< Diagnostic ids for tracer
!! tendencies due to sponges
integer, dimension(MAX_FIELDS_) :: id_sp_tendency = reshape([-1], [MAX_FIELDS_], [-1]) !< Diagnostic ids for tracer
!! tendencies due to sponges.
!! Init all to -1.
integer :: id_sp_u_tendency !< Diagnostic id for zonal momentum tendency due to
!! Rayleigh damping
integer :: id_sp_v_tendency !< Diagnostic id for meridional momentum tendency due to
Expand Down Expand Up @@ -671,7 +672,6 @@ subroutine init_ALE_sponge_diags(Time, G, diag, CS, US)
CS%diag => diag

do m=1,CS%fldno
CS%id_sp_tendency(m) = -1
if ((trim(CS%Ref_val(m)%unit) == 'none') .or. (len_trim(CS%Ref_val(m)%unit) == 0)) then
tend_unit = "s-1"
else
Expand Down