Fix bug in registration of ALE sponge diagnostics for generic tracers #1003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hallberg-NOAA
approved these changes
Dec 26, 2025
Member
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
These changes look sensible to me, although it should be noted that this change will probably change the order of entries in the available_diags file.
Hallberg-NOAA
force-pushed
the
generic-sponge-diag
branch
from
11fbd2a to
f789c31
Compare
Member
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/29653. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In NOAA-GFDL/CEFI-regional-MOM6#250, @CGjelstrup reported an issue where enabling the generic tracer sponge/nudging caused a crash due to an unregistered sponge tendency diagnostic. The issue was caused by the order in which the registration code for the sponge diagnostics and generic tracers is called--the sponge diags are registered before the generic tracers are set up, so the generic tracer sponge tendency diagnostics are never registered.
This PR fixes the issue by relocating the call to
init_ALE_sponge_diagsso that it is aftertracer_flow_control_init. It also makes sure that the array of sponge tendency diag ids,id_sp_tendency, is immediately initialized to -1s to help avoid any future bugs.For immediately initializing
id_sp_tendencyto -1s, I didI don't think this hack with
reshapeis done anywhere else in MOM6, but it was the best/only way I could figure out to initialize within atypedeclaration. If there's any issues with this just let me know.Also, I have this same PR open in the CEFI fork of MOM6---if you'd prefer it to go through CEFI first we could do that.