generalized indices: Modify unit tests to test nonstandard dimension orders #1763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the mpp_global_field unit tests to test nonstandard dimension orders. These new tests do not currently pass, as the mpp_global_field implementation uses hardcoded dimension orders.
J-Lentz
requested review from
bensonr,
rem1776,
uramirez8707 and
vithikashah001
as code owners
added 2 commits
September 4, 2025 09:49
Test the `mpp_*_group_update` subroutines with nonstandard dimension orders. A separate module for shared unit test code has also been created.
J-Lentz
changed the title
mpp_global_field unit testsmpp_global_field and mpp_*_group_update tests
added 2 commits
October 6, 2025 13:47
Modify the interpolator tests to test all possible dimension orders.
The 2D tests in test_data_override_ongrid.F90 have been modified to test for generalized indices support.
J-Lentz
changed the title
mpp_global_field and mpp_*_group_update tests
8 tasks
rem1776
requested changes
Dec 22, 2025
Contributor
rem1776
left a comment
rem1776
left a comment
There was a problem hiding this comment.
Just added a couple suggestions to use the preset autotools variable for the added module's include path, should be good to go in after the licensing is added.
added 2 commits
December 22, 2025 14:45
Skip the updated tests, which will not pass until the generalized indices work is complete.
uramirez8707
previously approved these changes
Dec 22, 2025
added 8 commits
January 8, 2026 10:13
As a workaround for gfortran 13, change `permutable_indices` from a parameterized derived type to separate types for 2D, 3D, and 4D.
uramirez8707
approved these changes
Jan 8, 2026
abrooks1085
approved these changes
Jan 9, 2026
vithikashah001
approved these changes
Jan 9, 2026
rem1776
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor the
mpp_global_field,mpp_*_group_update,interpolator, anddata_overrideunit tests to test nonstandard dimension orders. These new tests do not currently pass, as FMS currently uses hard-coded dimension orders. This PR also adds a new module containing shared code which is used by the modified unit tests.How Has This Been Tested?
New tests build successfully on C5 using intel-classic/2023.2.0. The tests pass when only the standard dimension orders are enabled, and fail when tests using other dimension orders are enabled.
Checklist:
make distcheckpasses