Generalized indices: mpp global field updates
#1806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the mpp_global_field unit tests to test nonstandard dimension orders. These new tests do not currently pass, as the mpp_global_field implementation uses hardcoded dimension orders.
Test the `mpp_*_group_update` subroutines with nonstandard dimension orders. A separate module for shared unit test code has also been created.
Modify the interpolator tests to test all possible dimension orders.
The 2D tests in test_data_override_ongrid.F90 have been modified to test for generalized indices support.
Update mpp_global_field unit tests to pass `xdim` and `ydim` arguments. Fix issues with the rewritten mpp_global_field that cause build errors and test failures.
Create a new file for `arr2vec`, `vec2arr`, and `arr_init`. Add interfaces for these new subroutines to mpp_domains_mod.
J-Lentz
requested review from
bensonr,
rem1776,
uramirez8707 and
vithikashah001
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
mpp_global_fieldupdates for generalized indices, and also includes the new unit tests introduced in #1763. TheMPP_DO_GLOBAL_FIELD_3D_subroutine is renamed toMPP_GLOBAL_FIELD_, which now takes assumed-ranklocalandglobalarguments. Optionalxdimandydimarguments have also been added, which can be used to specify which dimensions are domain-decomposed.MPP_DO_GLOBAL_FIELD_A2A_3D_is removed, as are the various wrapper subroutines formpp_global_field(MPP_GLOBAL_FIELD_2D_,MPP_GLOBAL_FIELD_4D_, etc). This PR also adds new subroutines for packing/unpacking 2D-5D arrays tompp_domains_mod.How Has This Been Tested?
Builds on C5 with intel-classic.
mpp_global_fieldunit tests pass.Checklist:
make distcheckpasses