Add an option to use liquid potential temperature in local mixing of GFSPBL #977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion of GFS PBL scheme. (from @WeiguoWang-NOAA)
13 tasks
grantfirl
reviewed
Jun 13, 2025
| real(kind=kind_phys) :: elmx = 300. !< maximum allowed dissipation mixing length in boundary layer mass flux scheme | ||
| integer :: sfc_rlm = 0 !< choice of near surface mixing length in boundary layer mass flux scheme | ||
| integer :: tc_pbl = 0 !< control for TC applications in the PBL scheme | ||
| integer :: use_lpt = 0 !< control for using Liquid Potential Temp for TC applications in the GFSPBL scheme |
Collaborator
There was a problem hiding this comment.
@WeiguoWang-NOAA If this can only ever be 0 or 1, can this be a logical instead?
Author
There was a problem hiding this comment.
@WeiguoWang-NOAA If this can only ever be 0 or 1, can this be a logical instead?
@grantfirl I would prefer to use an integer. Other different approximations could be developed in the future.
Collaborator
|
This PR has merged into PR #963 and will be processed there in. |
Collaborator
|
@DusanJovic-NOAA This can be closed since it was combined with #963 |
jkbk2004
pushed a commit
that referenced
this pull request
Jun 30, 2025
…uid potential temperature in local mixing of GFSPBL #977 (#963) * 3D-TKE EMDF GFS PBL scheme related changes from FIU (Ping Zhu, Ping.Zhu@noaa.gov). * Update changes in 3d TKE scheme * Add an option to use liquid potential temperature in temperature equation of GFS PBL scheme. (from @WeiguoWang-NOAA) * Update sa3dtke variables standard names * Update submodule physics for sa3dtke nonlocal mixing and stylistic coding * Update SA3DTKE variables names * Update submodules physics for SA3DTKE nonlocal mass-flux transport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a namelist option in GFS TKE EDMF PBL scheme to apply an approximate way to represent local mixing/diffusion process in T-equation using liquid/ice water potential temperature.
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?
Tests already made for HAFS application
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs