revert PR #837 changes to dev-v16 radinfo.f90

[RussTreadon-NOAA]

Description

This issues reverts changes made to src/gsi/radinfo.f90 in PR #837. This PR is identical to PR #974 with the exception that this PR merges the updated radinfo.f90 into develop-v16.

Resolves #932

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Run the 20260113 00 through 12Z analysis with the revised code with the satbias_pc.out from each run used in the successive run. The 2026011312 gnorm reduction curve is significantly improved with respect to the run using the current radinfo.f90.

ctests will be run but they are likely to show any difference since this bugfix is requires cycling to evaluate.

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• New and existing tests pass with my changes

[RussTreadon-NOAA]

WCOSS2 ctests

Install develop-v16 at 658a1e5 and RussTreadon-NOAA:bugfix/rad_varbc-v16 at e9ef1d4 on Dogwood. Run ctests with the following results:

Test project /lfs/h2/emc/da/noscrub/russ.treadon/git/gsi/rad_varbc-v16/build
    Start 1: global_4denvar
    Start 2: rtma
    Start 3: rrfs_3denvar_rdasens
    Start 4: hafs_4denvar_glbens
    Start 5: hafs_3denvar_hybens
    Start 6: global_enkf
1/6 Test #3: rrfs_3denvar_rdasens .............   Passed  852.57 sec
2/6 Test #6: global_enkf ......................   Passed  1218.68 sec
3/6 Test #5: hafs_3denvar_hybens ..............   Passed  1522.76 sec
4/6 Test #2: rtma .............................   Passed  1576.41 sec
5/6 Test #4: hafs_4denvar_glbens ..............   Passed  1704.52 sec
6/6 Test #1: global_4denvar ...................   Passed  2285.47 sec

100% tests passed, 0 tests failed out of 6

Total Test time (real) = 2285.60 sec

All tests Passed. This is an expected result.

[jack-woollen]

I approve. Thanks @RussTreadon-NOAA !

[RussTreadon-NOAA]

Thank you @jack-woollen and @ADCollard . I'll work with the Handling Review team to schedule merger of this PR into develop-v16.

[RussTreadon-NOAA]

@ShunLiu-NOAA , @CoryMartin-NOAA , @hu5970 : Andrew has write access to develop-v16 so his approval is sufficient. Hence the merger of this PR into develop-v16. I'm still stuck on GSI PR #974.

[RussTreadon-NOAA]

@ADCollard , @CatherineThomas-NOAA , @danholdaway

Both operations and the GFS v17 realtime gsi.x have encountered multiple cycles with poor convergence. Below is the time series of the final gnorm from the operational GDAS analysis

In recent days we see poor minimization on

• 2026011606
• 2026011706
• 2026011818
• 2020601912

The cases of poor minimization, the final gnorm spikes, occur in the cycle following a cycle with missing ssmis_f17 data

gdas.20260114/00/atmos/gdas.t00z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has   126840 reports
gdas.20260114/06/atmos/gdas.t06z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has   161880 reports
gdas.20260114/12/atmos/gdas.t12z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has   522000 reports
gdas.20260114/18/atmos/gdas.t18z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has   447540 reports
gdas.20260115/00/atmos/gdas.t00z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has   125520 reports
gdas.20260115/06/atmos/gdas.t06z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has   336900 reports
gdas.20260115/12/atmos/gdas.t12z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has   500880 reports
gdas.20260115/18/atmos/gdas.t18z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has   266280 reports
gdas.20260116/00/atmos/gdas.t00z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has    0 reports
gdas.20260116/06/atmos/gdas.t06z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has   136260 reports
gdas.20260116/12/atmos/gdas.t12z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has   112260 reports
gdas.20260116/18/atmos/gdas.t18z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has   145380 reports
gdas.20260117/00/atmos/gdas.t00z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has    0 reports
gdas.20260117/06/atmos/gdas.t06z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has   241500 reports
gdas.20260117/12/atmos/gdas.t12z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has   305460 reports
gdas.20260117/18/atmos/gdas.t18z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has   447780 reports
gdas.20260118/00/atmos/gdas.t00z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has   175920 reports
gdas.20260118/06/atmos/gdas.t06z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has   149220 reports
gdas.20260118/12/atmos/gdas.t12z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has    0 reports
gdas.20260118/18/atmos/gdas.t18z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has   223080 reports
gdas.20260119/00/atmos/gdas.t00z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has   145920 reports
gdas.20260119/06/atmos/gdas.t06z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has    0 reports
gdas.20260119/12/atmos/gdas.t12z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has   205020 reports
gdas.20260119/18/atmos/gdas.t18z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has   110520 reports
gdas.20260120/00/atmos/gdas.t00z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has   120300 reports

This PR reverts changes to the radiance bias correction variance made to develop-v16:src/gsi/radinfo.f90 inherited from changes to develop in PR #837.

When is our next operational GDAS implementation? This change should be in that implementation package.