revert PR #837 changes to develop radinfo.f90

[RussTreadon-NOAA]

Description

This issues reverts changes made to src/gsi/radinfo.f90 in PR #837.

Resolves #932

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Run the 20260113 00 through 12Z analysis with the revised code with the satbias_pc.out from each run used in the successive run. The 2026011312 gnorm reduction curve is significantly improved with respect to the run using the current radinfo.f90.

ctests will be run but they are likely to show any difference since this bugfix is requires cycling to evaluate.

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• New and existing tests pass with my changes

[RussTreadon-NOAA]

WCOSS2 ctests

Install develop at dcf055d and RussTreadon-NOAA:bugfix/rad_varbc at ecb5583 on Dogwood. Run ctests with the following results:

Test project /lfs/h2/emc/da/noscrub/russ.treadon/git/gsi/rad_varbc/build
    Start 1: global_4denvar
    Start 2: rtma
    Start 3: rrfs_3denvar_rdasens
    Start 4: hafs_4denvar_glbens
    Start 5: hafs_3denvar_hybens
    Start 6: global_enkf
1/6 Test #3: rrfs_3denvar_rdasens .............   Passed  736.22 sec
2/6 Test #6: global_enkf ......................   Passed  868.54 sec
3/6 Test #2: rtma .............................   Passed  1455.77 sec
4/6 Test #5: hafs_3denvar_hybens ..............   Passed  1523.52 sec
5/6 Test #4: hafs_4denvar_glbens ..............   Passed  1582.90 sec
6/6 Test #1: global_4denvar ...................   Passed  2226.80 sec

100% tests passed, 0 tests failed out of 6

Total Test time (real) = 2226.96 sec

All tests Passed. This is an expected result.

[RussTreadon-NOAA]

Thank you @ADCollard and @jack-woollen. I'll work with the Handling Review team to schedule merger of this PR into develop.

[RussTreadon-NOAA]

@CatherineThomas-NOAA

This PR corrects a bug in develop which impacts GSI minimization in certain situations. A check of the MinMon page for the realtime GFS v17 parallel shows poor minimization in the same cycles as operations.

Timeseries of operational gdas cycle final gnorm up to 2026011600

Timeseries of GFS v17 realtime gdas cycle final gnorm up to 2026011600

The common spikes represent cases of poor minimization. For example, the GDAS experienced poor convergence on 2026011312: operations, realtime GFS v17

We should update the GSI hash used by GFS v17 parallels once this PR is merged into develop. GSI PR #975 makes the same bugfix for the operational GSI (branch develop-v16).

[RussTreadon-NOAA]

Thank you @ShunLiu-NOAA ! Now I can merge.

[RussTreadon-NOAA]

@CatherineThomas-NOAA, @ADCollard , @danholdaway

Both operations and the GFS v17 realtime gsi.x have encountered multiple cycles with poor convergence. Below is the time series of the final gnorm from the GFS v17 realtime GDAS analysis

In recent days we see poor minimization on

• 2026011606
• 2026011706
• 2026011818
• 2020601912

The cases of poor minimization, the final gnorm spikes, occur in the cycle following a cycle with no ssmis_f17 data

gdas.20260114/00/atmos/gdas.t00z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has   126840 reports
gdas.20260114/06/atmos/gdas.t06z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has   161880 reports
gdas.20260114/12/atmos/gdas.t12z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has   522000 reports
gdas.20260114/18/atmos/gdas.t18z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has   447540 reports
gdas.20260115/00/atmos/gdas.t00z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has   125520 reports
gdas.20260115/06/atmos/gdas.t06z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has   336900 reports
gdas.20260115/12/atmos/gdas.t12z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has   500880 reports
gdas.20260115/18/atmos/gdas.t18z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has   266280 reports
gdas.20260116/00/atmos/gdas.t00z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has    0 reports
gdas.20260116/06/atmos/gdas.t06z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has   136260 reports
gdas.20260116/12/atmos/gdas.t12z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has   112260 reports
gdas.20260116/18/atmos/gdas.t18z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has   145380 reports
gdas.20260117/00/atmos/gdas.t00z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has    0 reports
gdas.20260117/06/atmos/gdas.t06z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has   241500 reports
gdas.20260117/12/atmos/gdas.t12z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has   305460 reports
gdas.20260117/18/atmos/gdas.t18z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has   447780 reports
gdas.20260118/00/atmos/gdas.t00z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has   175920 reports
gdas.20260118/06/atmos/gdas.t06z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has   149220 reports
gdas.20260118/12/atmos/gdas.t12z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has    0 reports
gdas.20260118/18/atmos/gdas.t18z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has   223080 reports
gdas.20260119/00/atmos/gdas.t00z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has   145920 reports
gdas.20260119/06/atmos/gdas.t06z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has    0 reports
gdas.20260119/12/atmos/gdas.t12z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has   205020 reports
gdas.20260119/18/atmos/gdas.t18z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has   110520 reports
gdas.20260120/00/atmos/gdas.t00z.status.tm00.bufr_d:         ---> 021.201 (in ssmisu) SAT. ID  285 has   120300 reports

This PR reverts changes to the radiance bias correction variance made to develop:src/gsi/radinfo.f90 in PR #837.

We should get this change into GFS v17 sooner rather than later.

[CatherineThomas-NOAA]

FYI: @RussTreadon-NOAA @ADCollard @danholdaway

This change is being added to the GFSv17 retrospective/realtime experiments with today's WCOSS2 production switch. We will be updating the Gaea clone today as well.

The GSI hash was updated in the global-workflow dev/gfs.v17 branch with NOAA-EMC/global-workflow#4500.