Skip to content

Re-enable EnKF-only for atmosphere #2051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RussTreadon-NOAA merged 2 commits into from
Jan 27, 2026
Merged

Re-enable EnKF-only for atmosphere #2051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d76b331
Enable EnKF-only for atmosphere (#2010)
bhuang95 Jan 23, 2026
299300a
re-enable enkf-only for atmosphere (#2050)
RussTreadon-NOAA Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions parm/atm/atm_ens_config.yaml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,5 +75,11 @@ data_out:
'${YMD}': current_cycle | to_YMD,
'${HH}': current_cycle | strftime('%H'),
'${MEMDIR}': 'mem%03d' | format(imem) }) %}
{% if DOENKFONLY_ATM | default(false) %}
{% for itile in range(1, ntiles + 1) %}
- ['{{ DATA }}/anl/{{ 'mem%03d' | format(imem) }}/{{ APREFIX_ENS }}cubed_sphere_grid_atminc.tile{{ itile }}.nc', '{{ COM_ATMOS_ANALYSIS_TMPL | replace_tmpl(tmpl_dict) }}/{{ APREFIX_ENS }}csg_jedi_increment.atm.i006.tile{{ itile }}.nc']
Copy link
Contributor Author

@RussTreadon-NOAA RussTreadon-NOAA Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parm/atm/atm_det_config.yaml.j2 copies from DATA to jedi_increment.atm.i006.tile*. There is no csg_ prefix on the deterministic individual tile files.

In contrast, the yaml above copies the ensemble jedi_increment tile from DATA to csg_jedi_increment.atm.i006.tile*. The ensemble DA files have a csg_ prefix on the individual tile files.

We should use the same convention for the deterministic and ensemble jedi_increment tile files.

Since the deterministic does not use the csg_ prefix, it seems we should drop the csg_ prefix for the ensmble jedi_increment tile files.

What do you think @bhuang95 , @DavidNew-NOAA , and @CoryMartin-NOAA ?

This inconsistency is causing failures in select g-w CI cases.

Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA Feb 9, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd have to look, but is this the distinction between the increment on the tiles and the increment on a Gaussian grid? Or are they both on the tiles?

EDIT: Scratch that, I can't read :-) If we have tileN in the file name, there is no need for csg in my opinion

Copy link
Contributor Author

@RussTreadon-NOAA RussTreadon-NOAA Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Inclusion of tile* in the filename clearly indicates that the file is a tiled file on the cube sphere grid.

Copy link
Contributor

@bhuang95 bhuang95 Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RussTreadon-NOAA The csg_ prefix was added in the workflow somepoint probaby last December. But my impression is whether to add it or not does not affect other parts. It should be good to remove it. Thanks for the change and merging it.

{% endfor %}
{% else %}
- ['{{ DATA }}/anl/{{ 'mem%03d' | format(imem) }}/{{ APREFIX_ENS }}cubed_sphere_grid_atminc.nc', '{{ COM_ATMOS_ANALYSIS_TMPL | replace_tmpl(tmpl_dict) }}/{{ APREFIX_ENS }}csg_jedi_increment.atm.i006.nc']
{% endif %}
{% endfor %}
19 changes: 19 additions & 0 deletions parm/atm/atm_ens_obs_dist_localizations.yaml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
obs_distribution_localizations:
obs_distribution:
name: {{ distribution_type }}
halo size: 1250e3
obs_localizations:
- localization method: Horizontal Gaspari-Cohn
lengthscale: 1250e3
max nobs: 10000

override_obs_distribution_localizations:
override: false
atms_n20:
obs_distribution:
name: {{ distribution_type }}
halo size: 850e3
obs_localizations:
- localization method: Horizontal Gaspari-Cohn
lengthscale: 850e3
max nobs: 5000
5 changes: 2 additions & 3 deletions parm/atm/jcb-base.yaml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,8 @@ local_ensemble_da_solver: Deterministic GETKF

increment_variables: [eastward_wind,northward_wind,layer_thickness,air_pressure_thickness,air_temperature,air_pressure_at_surface,water_vapor_mixing_ratio_wrt_moist_air,cloud_liquid_ice,cloud_liquid_water,snow_water,rain_water,graupel,ozone_mass_mixing_ratio]

atm_enkfonly: {{ DOENKFONLY_ATM | default(false, true) }}

# Veritcal localization for GETKF
vl_fraction_of_retained_variance: 0.750
vl_lengthscale: 2.1
Expand All @@ -145,9 +147,6 @@ driver_save_prior_mean: false
driver_save_posterior_mean_increment: false
driver_save_posterior_ensemble_increments: true

# Distribution type
distribution_type: Halo

# Diagnostics
atmosphere_ensemble_increment_prefix: "./anl/mem%{member}%/atminc."
atmosphere_posterior_output_gaussian: "./mem%{member}%/atmanl."
Expand Down
7 changes: 6 additions & 1 deletion parm/atm/jcb-prototype_lgetkf.yaml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Use observations for lgetkf
# ---------------------------
app_path_observations: {{PARMgfs}}/gdas/jcb-gdas/observations/atmosphere-lgetkf
app_path_observations: {{PARMgfs}}/gdas/jcb-gdas/observations/atmosphere
app_path_observation_chronicle: {{PARMgfs}}/gdas/jcb-gdas/observation_chronicle/atmosphere

# Algorithm
Expand All @@ -11,8 +11,13 @@ algorithm: local_ensemble_da
# ------------
atmosphere_background_ensemble_path: ./bkg/mem%mem%

# Observation distribution and localization
{% set distribution_type = "Halo" %}
{% include 'atm_ens_obs_dist_localizations.yaml.j2' %}

# Observation things
# ------------------
use_linear_observer: true
{% include OBS_LIST_YAML %}

# Testing things
Expand Down
7 changes: 4 additions & 3 deletions parm/atm/jcb-prototype_lgetkf_observer.yaml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Use observations for lgetkf
# ---------------------------
app_path_observations: {{PARMgfs}}/gdas/jcb-gdas/observations/atmosphere-lgetkf
app_path_observations: {{PARMgfs}}/gdas/jcb-gdas/observations/atmosphere
app_path_observation_chronicle: {{PARMgfs}}/gdas/jcb-gdas/observation_chronicle/atmosphere

# Algorithm
Expand All @@ -14,8 +14,9 @@ atmosphere_background_ensemble_path: ./bkg/mem%mem%
# Naming conventions for observation files
atmosphere_obsdataout_prefix: diag_lobs_

# Distribution type
distribution_type: RoundRobin
# Observation distribution and localization
{% set distribution_type = "RoundRobin" %}
{% include 'atm_ens_obs_dist_localizations.yaml.j2' %}

# Observation things
# ------------------
Expand Down
7 changes: 4 additions & 3 deletions parm/atm/jcb-prototype_lgetkf_solver.yaml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Use observations for lgetkf
# ---------------------------
app_path_observations: {{PARMgfs}}/gdas/jcb-gdas/observations/atmosphere-lgetkf
app_path_observations: {{PARMgfs}}/gdas/jcb-gdas/observations/atmosphere
app_path_observation_chronicle: {{PARMgfs}}/gdas/jcb-gdas/observation_chronicle/atmosphere

# Algorithm
Expand All @@ -17,8 +17,9 @@ atmosphere_obsdatain_prefix: diag_lobs_
atmosphere_obsdatain_suffix: "_{{ current_cycle | to_YMDH }}.nc"
atmosphere_obsdataout_prefix: diag_solv_

# Distribution type
distribution_type: Halo
# Observation distribution and localization
{% set distribution_type = "Halo" %}
{% include 'atm_ens_obs_dist_localizations.yaml.j2' %}

# Observation things
# ------------------
Expand Down
2 changes: 1 addition & 1 deletion parm/jcb-algorithms
Open in desktop
Submodule jcb-algorithms updated 1 files
+1 −0 observer_components.yaml
2 changes: 1 addition & 1 deletion sorc/jcb
Open in desktop
Submodule jcb updated 3 files
+27 −3 jcb_client_init.py
+2 −1 jcb_clients.yaml
+45 −0 src/jcb/renderer.py
Loading