Re-enable EnKF-only for atmosphere by RussTreadon-NOAA · Pull Request #2051 · NOAA-EMC/GDASApp

RussTreadon-NOAA · 2026-01-26T19:13:39Z

Description

This PR re-enables the changes from PRs #2010 and #2048.

Companion PRs

Successful GDASApp CI for this PR depend upon g-w PR #4472

Issues

Resolves #2050

Automated CI tests to run in Global Workflow

This PR works along with the following three dependent PRs to enable the EnKF-only configuration for the atmosphere within the global workflow (see detailed description NOAA-EMC/global-workflow#4345) Dependencies: -NOAA-EMC/global-workflow#4345 -NOAA-EMC/jcb-gdas#219 -NOAA-EMC/jcb#32 Resolve - NOAA-EMC/global-workflow#4339 --------- Co-authored-by: Bo Huang <[email protected]>

RussTreadon-NOAA · 2026-01-26T19:15:50Z

Keep this PR in draft mode until g-w PR #4472 is merged into g-w develop. g-w PR #4472 is currently undergoing CI testing on Gaea C6.

bhuang95

Looks good to me. Thanks for your update!

RussTreadon-NOAA · 2026-01-27T13:08:32Z

g-w PR #4472 has been merged into g-w develop. Now able to run GDASApp CI with select g-w CI for this PR.

emcbot · 2026-01-27T14:06:23Z

Automated GW-GDASApp Testing Results:
Machine: hercules

Start: Tue Jan 27 07:17:16 CST 2026 on hercules-login-1.hpc.msstate.edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Tue Jan 27 07:33:52 CST 2026
---------------------------------------------------
Tests: ctest -j12 -R gdasapp
Tests:                                 *SUCCESS*
Tests: Completed at Tue Jan 27 08:06:22 CST 2026
Tests: 100% tests passed, 0 tests failed out of 144

emcbot · 2026-01-27T14:14:04Z

Automated GW-GDASApp Testing Results:
Machine: ursa

Start: Tue Jan 27 13:17:16 UTC 2026 on ufe01
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Tue Jan 27 13:31:20 UTC 2026
---------------------------------------------------
Tests: ctest -j12 -R gdasapp
Tests:                                 *SUCCESS*
Tests: Completed at Tue Jan 27 14:14:03 UTC 2026
Tests: 100% tests passed, 0 tests failed out of 144

emcbot · 2026-01-27T14:22:07Z

Automated GW-GDASApp Testing Results:
Machine: hera

Start: Tue Jan 27 13:20:29 UTC 2026 on hfe02
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Tue Jan 27 13:41:22 UTC 2026
---------------------------------------------------
Tests: ctest -j12 -R gdasapp
Tests:                                 *SUCCESS*
Tests: Completed at Tue Jan 27 14:22:06 UTC 2026
Tests: 100% tests passed, 0 tests failed out of 144

emcbot · 2026-01-27T14:48:55Z

Automated GW-GDASApp Testing Results:
Machine: orion

Start: Tue Jan 27 07:17:54 AM CST 2026 on orion-login-1.hpc.msstate.edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Tue Jan 27 07:46:50 AM CST 2026
---------------------------------------------------
Tests: ctest -j12 -R gdasapp
Tests:                                 *SUCCESS*
Tests: Completed at Tue Jan 27 08:48:54 AM CST 2026
Tests: 100% tests passed, 0 tests failed out of 144

RussTreadon-NOAA · 2026-01-27T14:55:21Z

Automated GW-GDASApp Testing Results:
Machine: gaeac6

Start: Tue Jan 27 09:02:56 AM EST 2026 on gaea63
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Tue Jan 27 09:22:58 AM EST 2026
---------------------------------------------------
Tests: ctest -j12 -R gdasapp
Tests:                                 *SUCCESS*
Tests: Completed at Tue Jan 27 09:55:21 AM EST 2026
Tests: 100% tests passed, 0 tests failed out of 144

RussTreadon-NOAA · 2026-01-27T16:02:51Z

WCOSS2 GDASApp CI

Install feature/stable-nightly at 299300a inside g-w develop at 779b631 on Dogwood. Run GDASApp CI with the following results

Test project /lfs/h2/emc/da/noscrub/russ.treadon/git/global-workflow/stable-nightly/sorc/gdas.cd/build
        Start 221: test_gdasapp_C96C48_ufsgsi_hybatmDA
        Start 179: test_gdasapp_C96C48_hybatmDA
        Start 198: test_gdasapp_C96C48_ufs_hybatmDA
        Start 243: test_gdasapp_C96_gcafs_cycled
        Start 259: test_gdasapp_C96C48_hybatmsnowDA
        Start 280: test_gdasapp_C48mx500_3DVarAOWCDA
        Start 291: test_gdasapp_C48mx500_hybAOWCDA
        Start 306: test_gdasapp_setup_atm_jjob_cycled_exp
        Start 175: test_gdasapp_check_python_norms
        Start 176: test_gdasapp_check_yaml_keys
        Start 177: test_gdasapp_jcb_installation
        Start 178: test_gdasapp_snow_create_ens
  1/144 Test #176: test_gdasapp_check_yaml_keys .............................................   Passed    1.05 sec
        Start 305: test_gdasapp_convert_gsi_satbias
  2/144 Test #177: test_gdasapp_jcb_installation ............................................   Passed    2.14 sec
...
143/144 Test #316: test_gdasapp_atm_jjob_ens_inc ............................................   Passed   68.86 sec
        Start 317: test_gdasapp_atm_jjob_ens_final
144/144 Test #317: test_gdasapp_atm_jjob_ens_final ..........................................   Passed   36.05 sec

100% tests passed, 0 tests failed out of 144

Label Time Summary:
gdasapp    = 23424.89 sec*proc (138 tests)
script     = 23424.89 sec*proc (138 tests)

Total Test time (real) = 2633.54 sec

All tests Passed on Dogwood.

RussTreadon-NOAA · 2026-01-27T16:06:15Z

@CoryMartin-NOAA, @DavidNew-NOAA , and @bhuang95 : This PR is ready for merger into GDASApp develop. Thank you @bhuang95 for your approval. We need an approval with a developer with write access.

RussTreadon-NOAA · 2026-01-27T16:12:07Z

Thanks @CoryMartin-NOAA . Merging now.

RussTreadon-NOAA · 2026-02-07T18:36:24Z

parm/atm/atm_ens_config.yaml.j2

                         '${MEMDIR}': 'mem%03d' | format(imem) }) %}
+{% if DOENKFONLY_ATM | default(false) %}
+    {% for itile in range(1, ntiles + 1) %}
+    - ['{{ DATA }}/anl/{{ 'mem%03d' | format(imem) }}/{{ APREFIX_ENS }}cubed_sphere_grid_atminc.tile{{ itile }}.nc', '{{ COM_ATMOS_ANALYSIS_TMPL | replace_tmpl(tmpl_dict) }}/{{ APREFIX_ENS }}csg_jedi_increment.atm.i006.tile{{ itile }}.nc']


parm/atm/atm_det_config.yaml.j2 copies from DATA to jedi_increment.atm.i006.tile*. There is no csg_ prefix on the deterministic individual tile files.

In contrast, the yaml above copies the ensemble jedi_increment tile from DATA to csg_jedi_increment.atm.i006.tile*. The ensemble DA files have a csg_ prefix on the individual tile files.

We should use the same convention for the deterministic and ensemble jedi_increment tile files.

Since the deterministic does not use the csg_ prefix, it seems we should drop the csg_ prefix for the ensmble jedi_increment tile files.

What do you think @bhuang95 , @DavidNew-NOAA , and @CoryMartin-NOAA ?

This inconsistency is causing failures in select g-w CI cases.

I'd have to look, but is this the distinction between the increment on the tiles and the increment on a Gaussian grid? Or are they both on the tiles?

EDIT: Scratch that, I can't read :-) If we have tileN in the file name, there is no need for csg in my opinion

Agreed. Inclusion of tile* in the filename clearly indicates that the file is a tiled file on the cube sphere grid.

@RussTreadon-NOAA The csg_ prefix was added in the workflow somepoint probaby last December. But my impression is whether to add it or not does not affect other parts. It should be good to remove it. Thanks for the change and merging it.

bhuang95 and others added 2 commits January 26, 2026 16:32

re-enable enkf-only for atmosphere (#2050)

299300a

RussTreadon-NOAA self-assigned this Jan 26, 2026

RussTreadon-NOAA requested a review from bhuang95 January 26, 2026 19:13

RussTreadon-NOAA mentioned this pull request Jan 26, 2026

Enable EnKF-only for atmosphere #2050

Closed

bhuang95 approved these changes Jan 26, 2026

View reviewed changes

RussTreadon-NOAA mentioned this pull request Jan 27, 2026

Enable EnKF-only for atmosphere NOAA-EMC/global-workflow#4345

Merged

24 tasks

RussTreadon-NOAA added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion hercules-GW-RT Queue for automated testing with global-workflow on Hercules ursa-GW-RT gaeac6-GW-RT labels Jan 27, 2026

RussTreadon-NOAA added gaeac6-GW-RT-Running and removed gaeac6-GW-RT labels Jan 27, 2026

emcbot added hercules-GW-RT-Passed Automated testing with global-workflow successful on Hercules and removed hercules-GW-RT-Running Automated testing with global-workflow running on Hercules labels Jan 27, 2026

emcbot added ursa-GW-RT-Passed and removed ursa-GW-RT-Running labels Jan 27, 2026

emcbot added hera-GW-RT-Passed Automated testing with global-workflow successful on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Jan 27, 2026

emcbot added orion-GW-RT-Passed Automated testing with global-workflow successful on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Jan 27, 2026

RussTreadon-NOAA added gaeac6-GW-RT-Passed and removed gaeac6-GW-RT-Running labels Jan 27, 2026

RussTreadon-NOAA marked this pull request as ready for review January 27, 2026 16:04

RussTreadon-NOAA requested a review from CoryMartin-NOAA January 27, 2026 16:04

RussTreadon-NOAA requested a review from DavidNew-NOAA January 27, 2026 16:06

CoryMartin-NOAA approved these changes Jan 27, 2026

View reviewed changes

RussTreadon-NOAA merged commit 326262a into develop Jan 27, 2026
36 checks passed

RussTreadon-NOAA deleted the feature/stable-nightly branch January 27, 2026 16:12

RussTreadon-NOAA commented Feb 7, 2026

View reviewed changes

Conversation

RussTreadon-NOAA commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Companion PRs

Issues

Automated CI tests to run in Global Workflow

Uh oh!

RussTreadon-NOAA commented Jan 26, 2026

Uh oh!

bhuang95 left a comment

Choose a reason for hiding this comment

Uh oh!

RussTreadon-NOAA commented Jan 27, 2026

Uh oh!

emcbot commented Jan 27, 2026

Uh oh!

emcbot commented Jan 27, 2026

Uh oh!

emcbot commented Jan 27, 2026

Uh oh!

emcbot commented Jan 27, 2026

Uh oh!

RussTreadon-NOAA commented Jan 27, 2026

Uh oh!

RussTreadon-NOAA commented Jan 27, 2026

Uh oh!

RussTreadon-NOAA commented Jan 27, 2026

Uh oh!

RussTreadon-NOAA commented Jan 27, 2026

Uh oh!

Uh oh!

RussTreadon-NOAA Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

CoryMartin-NOAA Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RussTreadon-NOAA Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

bhuang95 Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

RussTreadon-NOAA commented Jan 26, 2026 •

edited

Loading

CoryMartin-NOAA Feb 9, 2026 •

edited

Loading