Enable EnKF-only for atmosphere#2010
Conversation
… hard-coded (need to revisit)
This PR works along with the following three dependent PRs to enable the EnKF-only configuration for the atmosphere within the global workflow (see detailed description NOAA-EMC/global-workflow#4345) Dependencies: -NOAA-EMC/global-workflow#4345 -NOAA-EMC/GDASApp#2010 -NOAA-EMC/jcb-gdas#219 Resolve - NOAA-EMC/global-workflow#4339 --------- Co-authored-by: Cory Martin <[email protected]>
|
@CoryMartin-NOAA I updated this branch with develop. It now has issues of reading the obs distribution and localization blocks in atm_ens_obs_dist_localizations.yaml.j2 |
|
@bhuang95 I ran into this same problem on Thursday. I don't immediately know what new change broke this, but I think the fix is this: NOAA-EMC/wxflow#65 |
This PR works along with the following three dependent PRs to enable the EnKF-only configuration for the atmosphere within the global workflow (see detailed description NOAA-EMC/global-workflow#4345) Dependencies: -NOAA-EMC/global-workflow#4345 -NOAA-EMC/GDASApp#2010 -NOAA-EMC/jcb#32 Resolve - NOAA-EMC/global-workflow#4339 --------- Co-authored-by: Cory Martin <[email protected]>
CoryMartin-NOAA
left a comment
CoryMartin-NOAA
left a comment
There was a problem hiding this comment.
Looks good, thanks @bhuang95 I'm going to test this and then approve if it works well
CoryMartin-NOAA
left a comment
CoryMartin-NOAA
left a comment
There was a problem hiding this comment.
Approved but we need to not merge until the workflow PR is ready or else things will be broken
CoryMartin-NOAA
left a comment
CoryMartin-NOAA
left a comment
There was a problem hiding this comment.
Tested manually on WCOSS2, and confirmed that it creates a YAML for the observer that looks good. Thanks, this will really help with YAML maintenance going forward.
|
FYI: @bhuang95 and @CoryMartin-NOAA Updated |
|
@RussTreadon-NOAA well that is odd, I tested with the develop branch of the workflow. Clearly I screwed something up. Do you have logs I can look at? |
|
@CoryMartin-NOAA : GDASApp CI ran on Hera in
This is a copy of g-w The GDASApp ctest log file is Log files for atm_jjob_ens are in Log files for C96C48_ufs_hybatmDA are in |
|
|
|
@RussTreadon-NOAA ah okay I think I already know what the problem is. I was using develop of JCB by accident. We need JCB updated into the global workflow before we can update the GDAS hash. |
|
@CoryMartin-NOAA . I updated $HOMEgfs/sorc/gdas.cd/sorc/jcb to d7bd27b. I reran atm_jjob_ens. The ens_init job failed with I updated Did I correctly make the change you suggested? |
|
Yikes, sorry @RussTreadon-NOAA my workflow checkout was not as fresh as I thought. You also need develop of |
|
Update test_gdasapp_atm_jjob_ens_letkf did not pass. It was killed by the system when it reached the specified 30 minute wall clock limit. Comparison of the atmensanlobs.yaml and atmensanlsol.yaml from this rerun and those from yesterday's stable-nightly runs show numerous differences. This makes sense. PR #2010 replaced the use of |
|
@CoryMartin-NOAA and @bhuang95: Several GDASApp tests are broken. The stable-nightly run will fail tonight and thereafter until we decide on a path forward. |
|
@RussTreadon-NOAA what is your preference? Do we want to revert this PR? Do we need to be more selective on which observations are assimilated in the CI test? Do we accept the stable nightly will fail over the weekend? |
|
@RussTreadon-NOAA I don't know why this is just now showing up, but at least some of the errors are related to this file: I think we need |
|
@CoryMartin-NOAA and @bhuang95 : Ideally we create a g-w branch that works with the current head of GDASApp Reverting this PR restores things to where they were for last night's stable-nightly run. This leaves us with a GDASApp |
This reverts commit 9fe6905.
This reverts commit 9fe6905. # Description Will investigate issues further on Monday to un-revert this and include updates to jcb-algorithms and jcb # Companion PRs <!-- Enter links to any companion PRs here. --> # Issues <!-- Enter any issues referenced or resolved by this PR here. Use keywords "Resolves" or "Refs". Resolves #1234 Refs #4321 Refs NOAA-EMC/repo#5678 --> # Automated CI tests to run in Global Workflow <!-- Which Global Workflow CI tests are required to adequately test this PR? --> - [ ] atm_jjob <!-- JEDI atm single cycle DA !--> - [ ] C96C48_ufs_hybatmDA <!-- JEDI atm cycled DA !--> - [ ] C96C48_hybatmsnowDA <!-- JEDI snow cycled DA !--> - [ ] C96_gcafs_cycled <!-- JEDI aerosol cycled DA !--> - [ ] C48mx500_3DVarAOWCDA <!-- JEDI low-res marine 3DVar cycled DA !--> - [ ] C48mx500_hybAOWCDA <!-- JEDI marine hybrid envar cycled DA !--> - [ ] C96C48_ufsgsi_hybatmDA <!-- JEDI atm Var with GSI EnKF cycled DA !--> - [ ] C96C48_hybatmDA <!-- GSI atm cycled DA !-->
@CoryMartin-NOAA |
|
Thanks @bhuang95 I'm surprised we didn't notice this until now that the section of YAML gets scrubbed |
|
@CoryMartin-NOAA and @bhuang95 : Can you accumulate either in this PR or a new issue/PR all the submodules@hash we expect to use in order to enable enkf-only for atmosphere? I'll create a working copy of g-w with these components for testing purposes. |
This PR works along with the following three dependent PRs to enable the EnKF-only configuration for the atmosphere within the global workflow (see detailed description NOAA-EMC/global-workflow#4345) Dependencies: -NOAA-EMC/global-workflow#4345 -NOAA-EMC/jcb-gdas#219 -NOAA-EMC/jcb#32 Resolve - NOAA-EMC/global-workflow#4339 --------- Co-authored-by: Bo Huang <[email protected]>
4 participants
This PR works along with the following three dependent PRs to enable the EnKF-only configuration for the atmosphere within the global workflow (see detailed description NOAA-EMC/global-workflow#4345)
Dependencies:
-NOAA-EMC/global-workflow#4345
-NOAA-EMC/jcb-gdas#219
-NOAA-EMC/jcb#32
Resolve