Skip to content

Jwade reservoir da#110

Merged
jswade-rtx merged 8 commits into
developmentfrom
jwade_reservoir_da
Jul 22, 2026
Merged

Jwade reservoir da#110
jswade-rtx merged 8 commits into
developmentfrom
jwade_reservoir_da

Conversation

@jswade-rtx

@jswade-rtx jswade-rtx commented Jul 15, 2026

Copy link
Copy Markdown

Adds support for reservoir RFC data assimilation in t-route, controlled by a new optional [DataAssimilation] section in input.config (reservoir_da bool, reservoir_rfc_dir path). Only applies to default, forecast, and regionalization runs. Reservoir DA not permitted for calibrations.

Adds DataAssimilationConfig/DataAssimilation field to InputConfig, with validation that reservoir_rfc_dir exists when reservoir_da is True. create_troute_config and update_troute now accept da_sec and population the t-route reservoir_rfc_da block accordingly.

This PR also turns on t-route's lakeout_output by default.

@jswade-rtx
jswade-rtx force-pushed the jwade_reservoir_da branch from af15981 to 308dbe6 Compare July 16, 2026 14:47
@mxkpp
mxkpp self-requested a review July 20, 2026 15:54

@mxkpp mxkpp left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not versed in t-route configuration but the intent of the changes seem reasonable. Just one question about the new logger.warning call.

Comment thread src/mswm/utils/ginputfunc.py Outdated
@mxkpp
mxkpp self-requested a review July 20, 2026 19:00
@jswade-rtx
jswade-rtx merged commit f8ef8f8 into development Jul 22, 2026
7 checks passed
@jswade-rtx
jswade-rtx deleted the jwade_reservoir_da branch July 22, 2026 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants