Jwade reservoir da#110
Merged
Merged
Conversation
jswade-rtx
force-pushed
the
jwade_reservoir_da
branch
from
July 16, 2026 14:47
af15981 to
308dbe6
Compare
mxkpp
self-requested a review
July 20, 2026 15:54
mxkpp
requested changes
Jul 20, 2026
mxkpp
left a comment
There was a problem hiding this comment.
I am not versed in t-route configuration but the intent of the changes seem reasonable. Just one question about the new logger.warning call.
mxkpp
self-requested a review
July 20, 2026 19:00
mxkpp
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for reservoir RFC data assimilation in t-route, controlled by a new optional
[DataAssimilation]section ininput.config(reservoir_dabool,reservoir_rfc_dirpath). Only applies to default, forecast, and regionalization runs. Reservoir DA not permitted for calibrations.Adds
DataAssimilationConfig/DataAssimilationfield toInputConfig, with validation thatreservoir_rfc_direxists whenreservoir_daisTrue.create_troute_configandupdate_troutenow acceptda_secand population the t-routereservoir_rfc_dablock accordingly.This PR also turns on t-route's
lakeout_outputby default.