Implement reservoir RFC da#22
Merged
Merged
Conversation
mxkpp
approved these changes
Jul 20, 2026
mxkpp
left a comment
mxkpp
left a comment
There was a problem hiding this comment.
Changes are reasonable when looking at pending mswm changes in NGWPC/nwm-msw-mgr#110. Minor request to sync up the example dir among the various example shell scripts.
|
Latest changes look good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an option
--reservoir_rfc_dirCLI arg to nwm-rte (forecast, default, and regionalization scripts). When provided, it's passed through to the msw-mgr's newDataAssimilationConfig, automatically settingreservoir_da=Trueto enable reservoir RFC data assimilation in t-route and passing the location of processed RFC throughreservoir_rfc_dir.