Add mujoco_vendor integration
#30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eholum-nasa
reviewed
Nov 10, 2025
Member
eholum-nasa
left a comment
eholum-nasa
left a comment
There was a problem hiding this comment.
Thanks all! It'll be great to have the vendor package available. Added some nit picky things but overall looks great!
With the change above we could merge this now, but it'll break rosdep installs unless users explicitly ignore the failure. Do we want to wait for the sync to merge this?
Contributor
Author
Yes, let's hold this PR until we have the rosdep releases done. |
Co-authored-by: Erik Holum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have recently added https://github.com/pal-robotics/mujoco_vendor integration. I'm waiting for this to do an official release: ros2-gbp/ros2-gbp-github-org#895
Thanks to the work of @Ortisa