Skip to content

feat(node): disable immediate data deletion after BlobDeleted events by default#3160

Merged
mlegner merged 1 commit intomainfrom
mlegner/wal-1190-allow-enablingdisabling-immediate-data-deletion-after
Mar 19, 2026
Merged

feat(node): disable immediate data deletion after BlobDeleted events by default#3160
mlegner merged 1 commit intomainfrom
mlegner/wal-1190-allow-enablingdisabling-immediate-data-deletion-after

Conversation

@mlegner
Copy link
Contributor

@mlegner mlegner commented Mar 19, 2026

Description

Add a new configuration parameter garbage_collection.enable_immediate_data_deletion, which defaults to false. When processing a BlobDeleted event, data is only deleted immediately if this parameter is set to true.

Test plan

Added a new test case that tests the expected behavior for both enabled and disabled immediate data deletion.


Release notes

  • Storage node: Add a new configuration parameter garbage_collection.enable_immediate_data_deletion, which defaults to false. When processing a BlobDeleted event, data is only deleted immediately if this parameter is set to true.

@mlegner mlegner requested review from halfprice and sadhansood March 19, 2026 14:20
@mlegner mlegner self-assigned this Mar 19, 2026
@github-actions
Copy link
Contributor

Warning: This PR modifies one of the example config files. Please consider the
following:

  • Make sure the changes are backwards compatible with the current configuration.
  • Make sure any added parameters follow the conventions of the existing parameters; in
    particular, durations should take seconds or milliseconds using the naming convention
    _secs or _millis, respectively.
  • If there are added optional parameter sections, it should be possible to specify them
    partially. A useful pattern there is to implement Default for the struct and derive
    #[serde(default)] on it, see BlobRecoveryConfig as an example.
  • You may need to update the documentation to reflect the changes.

@mlegner mlegner force-pushed the mlegner/wal-1190-allow-enablingdisabling-immediate-data-deletion-after branch from d7f2d7a to 834ef09 Compare March 19, 2026 14:49
@halfprice
Copy link
Collaborator

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. More of your lovely PRs please.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@sadhansood
Copy link
Contributor

Just a question - what happens to these blobs which are skipping to delete, we will be able to delete them during periodic end of epoch cleanup i think?

@mlegner
Copy link
Contributor Author

mlegner commented Mar 19, 2026

Just a question - what happens to these blobs which are skipping to delete, we will be able to delete them during periodic end of epoch cleanup i think?

Yes, exactly. Those would be cleaned up during the "normal" GC process.

@mlegner mlegner merged commit ad4b851 into main Mar 19, 2026
26 checks passed
@mlegner mlegner deleted the mlegner/wal-1190-allow-enablingdisabling-immediate-data-deletion-after branch March 19, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants