Conversation
|
Warning: This PR modifies one of the example config files. Please consider the
|
d7f2d7a to
834ef09
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Just a question - what happens to these blobs which are skipping to delete, we will be able to delete them during periodic end of epoch cleanup i think? |
Yes, exactly. Those would be cleaned up during the "normal" GC process. |
Description
Add a new configuration parameter
garbage_collection.enable_immediate_data_deletion, which defaults tofalse. When processing aBlobDeletedevent, data is only deleted immediately if this parameter is set to true.Test plan
Added a new test case that tests the expected behavior for both enabled and disabled immediate data deletion.
Release notes
garbage_collection.enable_immediate_data_deletion, which defaults tofalse. When processing aBlobDeletedevent, data is only deleted immediately if this parameter is set to true.