Skip to content

feat(node): disable immediate data deletion after BlobDeleted events by default#3161

Merged
halfprice merged 3 commits intoreleases/walrus-v1.44.0-releasefrom
mlegner/v1.44-cherry-picks/3160
Mar 19, 2026
Merged

feat(node): disable immediate data deletion after BlobDeleted events by default#3161
halfprice merged 3 commits intoreleases/walrus-v1.44.0-releasefrom
mlegner/v1.44-cherry-picks/3160

Conversation

@mlegner
Copy link
Contributor

@mlegner mlegner commented Mar 19, 2026

Description

Cherry-picks #3160 into the v1.44 release.

Test plan

See #3160.


Release notes

  • Storage node: Add a new configuration parameter garbage_collection.enable_immediate_data_deletion, which defaults to false. When processing a BlobDeleted event, data is only deleted immediately if this parameter is set to true.

@mlegner mlegner requested review from halfprice and sadhansood March 19, 2026 14:21
@github-actions
Copy link
Contributor

Warning: This PR modifies one of the example config files. Please consider the
following:

  • Make sure the changes are backwards compatible with the current configuration.
  • Make sure any added parameters follow the conventions of the existing parameters; in
    particular, durations should take seconds or milliseconds using the naming convention
    _secs or _millis, respectively.
  • If there are added optional parameter sections, it should be possible to specify them
    partially. A useful pattern there is to implement Default for the struct and derive
    #[serde(default)] on it, see BlobRecoveryConfig as an example.
  • You may need to update the documentation to reflect the changes.

@mlegner mlegner force-pushed the mlegner/v1.44-cherry-picks/3160 branch from e50fa85 to 9bca919 Compare March 19, 2026 14:49
@mlegner mlegner enabled auto-merge (squash) March 19, 2026 17:05
@halfprice halfprice added the ci:less-simtest-seeds Run simtests with less seeds in CI: label Mar 19, 2026
@halfprice halfprice disabled auto-merge March 19, 2026 17:15
@halfprice halfprice enabled auto-merge (squash) March 19, 2026 17:16
@halfprice halfprice merged commit 83a4e03 into releases/walrus-v1.44.0-release Mar 19, 2026
23 of 24 checks passed
@halfprice halfprice deleted the mlegner/v1.44-cherry-picks/3160 branch March 19, 2026 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:less-simtest-seeds Run simtests with less seeds in CI:

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants