Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Add and implement CSSElement interface #1231

Merged
merged 2 commits into from
Apr 9, 2025
Merged

[TASK] Add and implement CSSElement interface #1231

merged 2 commits into from
Apr 9, 2025

Conversation

JakeQZ
Copy link
Contributor

@JakeQZ JakeQZ commented Apr 2, 2025 •
edited
Loading

Also add tests to confirm that the supplanted types in the DocBlock actually implement the new interface.

And correct a DocBlock type to also allow string, which is currently possible.

cf. #1230

@JakeQZ JakeQZ added the cleanup label Apr 2, 2025
@JakeQZ JakeQZ self-assigned this Apr 2, 2025
@JakeQZ JakeQZ marked this pull request as draft April 2, 2025 23:32
@coveralls
Copy link

coveralls commented Apr 2, 2025 •
edited
Loading

Coverage Status

coverage: 53.315%. remained the same
when pulling 92b0ebf on task/csselement-interface
into 4e107ac on main.

@JakeQZ JakeQZ force-pushed the task/csselement-interface branch 5 times, most recently from c93a78c to 94900e2 Compare April 7, 2025 23:49
@JakeQZ JakeQZ changed the title [TASK] Add CSSElement interface [TASK] Add and implement CSSElement interface Apr 7, 2025
@JakeQZ JakeQZ marked this pull request as ready for review April 7, 2025 23:57
@JakeQZ JakeQZ requested review from sabberworm and oliverklee April 7, 2025 23:57
@JakeQZ JakeQZ added the refactor For PRs that refactor code without changing functionality label Apr 7, 2025
@JakeQZ JakeQZ mentioned this pull request Apr 8, 2025
Closed
@JakeQZ
[TASK] Add and implement CSSElement interface
7576c8c 
Also add tests to confirm that the supplanted types in the DocBlock actually
implement the new interface.

And correct a DocBlock type to also allow `string`,
which is currently possible.

cf. #1230
@JakeQZ JakeQZ force-pushed the task/csselement-interface branch from 94900e2 to 7576c8c Compare April 8, 2025 01:03
oliverklee
oliverklee requested changes Apr 8, 2025
View reviewed changes
Copy link
Contributor

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good in general. Just a few minor nits.

@JakeQZ JakeQZ requested a review from oliverklee April 8, 2025 15:50
@JakeQZ JakeQZ mentioned this pull request Apr 8, 2025
Merged
@oliverklee oliverklee merged commit b74cf2e into main Apr 9, 2025
21 checks passed
@oliverklee oliverklee deleted the task/csselement-interface branch April 9, 2025 12:44
JakeQZ added a commit that referenced this pull request Apr 11, 2025
@JakeQZ
[TASK] Deconflate getAllValues() parameters
8b7a2b8 
This is the backport of #1231, #1240 and #1241.

cf. #1230
@JakeQZ JakeQZ mentioned this pull request Apr 11, 2025
Merged
JakeQZ added a commit that referenced this pull request Apr 11, 2025
@JakeQZ
[TASK] Deconflate getAllValues() parameters
4a5e284 
This is the backport of #1231, #1240 and #1241.

cf. #1230
oliverklee pushed a commit that referenced this pull request Apr 12, 2025
@JakeQZ
[TASK] Deconflate getAllValues() parameters (#1242)
f5fc39a 
This is the backport of #1231, #1240 and #1241.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverklee oliverklee oliverklee approved these changes

@sabberworm sabberworm Awaiting requested review from sabberworm

Assignees

@JakeQZ JakeQZ

Labels
cleanup refactor For PRs that refactor code without changing functionality to-backport
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@JakeQZ @coveralls @oliverklee