Skip to content

Add assertInstanceOf tests for newly introduced interfaces #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JakeQZ opened this issue Apr 8, 2025 · 0 comments · Fixed by #1237
Closed

Add assertInstanceOf tests for newly introduced interfaces #1236

JakeQZ opened this issue Apr 8, 2025 · 0 comments · Fixed by #1237
Labels
testing PRs/issues adding additional tests only, or primarily testing-focused
Milestone
9.0.0: Drop suppo...

Comments

@JakeQZ
Copy link
Contributor

JakeQZ commented Apr 8, 2025 •
edited
Loading

Some new interface types have been added to replace an orred type list for some methods. Possibly only CSSListItem (#1212) is relevant here. (Positionable was also added, but this is not used as a type for any parameter, and only exists to complement the Position trait.)

During those changes, tests should have been added to confirm that the classes replaced in the parameter lists actually implement the replacement all-encompassing type.

#1231 has a similar change, and includes relevant tests.
@JakeQZ JakeQZ added the testing PRs/issues adding additional tests only, or primarily testing-focused label Apr 8, 2025
JakeQZ added a commit that referenced this issue Apr 8, 2025
@JakeQZ
[TASK] Add assertInstanceOf tests for CSSListItem
cb72467 
These should probably have been added as part of #1212.
They confirm that the various types supplanted by `CSSListItem` in the API all
implement the new interface.

Resolves #1236.
@JakeQZ JakeQZ mentioned this issue Apr 8, 2025
Merged
JakeQZ added a commit that referenced this issue Apr 9, 2025
@JakeQZ
[TASK] Add assertInstanceOf tests for CSSListItem
dea50e5 
These should probably have been added as part of #1212.
They confirm that the various types supplanted by `CSSListItem` in the API all
implement the new interface.

Resolves #1236.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing PRs/issues adding additional tests only, or primarily testing-focused
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging a pull request may close this issue.

[TASK] Add assertInstanceOf tests for CSSListItem MyIntervals/PHP-CSS-Parser
1 participant
@JakeQZ