Skip to content

MCR-3668 Remove MCRConfigurableInstanceHelper, move value-class-determination into MCRInstanceConfiguration#2922

Draft
toKrause wants to merge 1 commit intomainfrom
issues/MCR-3668_remove-MCRConfigurableInstanceHelper-move-value-class-determination-into-MCRInstanceConfiguration
Draft

MCR-3668 Remove MCRConfigurableInstanceHelper, move value-class-determination into MCRInstanceConfiguration#2922
toKrause wants to merge 1 commit intomainfrom
issues/MCR-3668_remove-MCRConfigurableInstanceHelper-move-value-class-determination-into-MCRInstanceConfiguration

Conversation

@toKrause
Copy link
Copy Markdown
Contributor

@toKrause toKrause commented Apr 21, 2026

Link to jira.

Pull Request Checklist (Author)

Please go through the following checklist before assigning the PR for review:

Ticket & Documentation

  • The issue in the ticket is clearly described and the solution is documented.
  • Design decisions (if any) are explained.
  • The ticket references the correct source and target branches.
  • The fixed-version is correctly set in the ticket and matches the PR's target branch (main).

Feature & Improvement Specific Checks

  • Instructions on how to test or use the feature are included or linked (e.g. to documentation).
  • For UI changes: before & after screenshots are attached.
  • New features or migrations are documented.
  • Does this change affect existing applications, data, or configurations?
    • Yes: Is a migration required? If yes, describe it.
    • Breaking change is marked in the commit message.

Testing

  • I have tested the changes locally.
  • The feature behaves as described in the ticket.
  • Were existing tests modified?
    • Yes: explain the changes for reviewers.

MCR Conventions & Metadata

  • MCR naming conventions are followed
  • If the public API has changed:
    • Old API is deprecated or a migration is documented.
    • If not, no action needed.
  • Java license headers are added where necessary.
  • Javadoc is written for non-self-explanatory classes/methods (Clean Code).
  • All configuration options are documented in Javadoc and mycore.properties.
  • No default properties are hardcoded — all set via mycore.properties.

Multi-Repo Considerations

  • Is an equivalent PR in MIR required?
    • If yes, is it already created?

@toKrause toKrause changed the title MCR-3668 Remove MCRConfigurableInstanceHelper, move value-class-determination into MCRINstanceConfiguration MCR-3668 Remove MCRConfigurableInstanceHelper, move value-class-determination into MCRInstanceConfiguration Apr 21, 2026
@toKrause toKrause force-pushed the issues/MCR-3668_remove-MCRConfigurableInstanceHelper-move-value-class-determination-into-MCRInstanceConfiguration branch 2 times, most recently from bf1d799 to 7a0c525 Compare May 1, 2026 19:04
@toKrause toKrause force-pushed the issues/MCR-3668_remove-MCRConfigurableInstanceHelper-move-value-class-determination-into-MCRInstanceConfiguration branch 7 times, most recently from 2f51f2c to 5e1d7d1 Compare May 5, 2026 01:03
@toKrause toKrause force-pushed the issues/MCR-3668_remove-MCRConfigurableInstanceHelper-move-value-class-determination-into-MCRInstanceConfiguration branch from 5e1d7d1 to 9c47a94 Compare May 5, 2026 11:38
@toKrause toKrause marked this pull request as draft May 5, 2026 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant