Skip to content

MCR-3699 Change MCRSentinel from nested into top-level annotation#2936

Draft
toKrause wants to merge 3 commits intomainfrom
issues/MCR-3699_Turn-MCRSentinel-from-nested-into-into-top-level-annotation
Draft

MCR-3699 Change MCRSentinel from nested into top-level annotation#2936
toKrause wants to merge 3 commits intomainfrom
issues/MCR-3699_Turn-MCRSentinel-from-nested-into-into-top-level-annotation

Conversation

@toKrause
Copy link
Copy Markdown
Contributor

@toKrause toKrause commented May 2, 2026

Link to jira.

Relies on #2922.

Pull Request Checklist (Author)

Please go through the following checklist before assigning the PR for review:

Ticket & Documentation

  • The issue in the ticket is clearly described and the solution is documented.
  • Design decisions (if any) are explained.
  • The ticket references the correct source and target branches.
  • The fixed-version is correctly set in the ticket and matches the PR's target branch (main).

Feature & Improvement Specific Checks

  • Instructions on how to test or use the feature are included or linked (e.g. to documentation).
  • For UI changes: before & after screenshots are attached.
  • New features or migrations are documented.
  • Does this change affect existing applications, data, or configurations?
    • Yes: Is a migration required? If yes, describe it.
    • Breaking change is marked in the commit message.

Testing

  • I have tested the changes locally.
  • The feature behaves as described in the ticket.
  • Were existing tests modified?
    • Yes: explain the changes for reviewers.

MCR Conventions & Metadata

  • MCR naming conventions are followed
  • If the public API has changed:
    • Old API is deprecated or a migration is documented.
    • If not, no action needed.
  • Java license headers are added where necessary.
  • Javadoc is written for non-self-explanatory classes/methods (Clean Code).
  • All configuration options are documented in Javadoc and mycore.properties.
  • No default properties are hardcoded — all set via mycore.properties.

Multi-Repo Considerations

  • Is an equivalent PR in MIR required?
    • If yes, is it already created?

@toKrause toKrause changed the title MCR-699 Change MCRSentinel from nested into top-level annotation MCR-3699 Change MCRSentinel from nested into top-level annotation May 2, 2026
@toKrause toKrause force-pushed the issues/MCR-3699_Turn-MCRSentinel-from-nested-into-into-top-level-annotation branch 4 times, most recently from 5024ac0 to b290663 Compare May 4, 2026 11:41
sebhofmann

This comment was marked as duplicate.

@toKrause toKrause force-pushed the issues/MCR-3699_Turn-MCRSentinel-from-nested-into-into-top-level-annotation branch from b290663 to af90af0 Compare May 4, 2026 21:10
@toKrause toKrause force-pushed the issues/MCR-3699_Turn-MCRSentinel-from-nested-into-into-top-level-annotation branch from af90af0 to 8fda6be Compare May 5, 2026 01:09
@toKrause toKrause force-pushed the issues/MCR-3699_Turn-MCRSentinel-from-nested-into-into-top-level-annotation branch from 8fda6be to a0c1da6 Compare May 5, 2026 01:13
@toKrause toKrause marked this pull request as draft May 5, 2026 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants