Skip to content

feat: enable bitcoin bip44 #36510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 8, 2025
+91 −404
Merged

feat: enable bitcoin bip44 #36510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8e5630b
feat: enable bitcoin bip44
aganglada Oct 1, 2025
b53661c
fix: test
aganglada Oct 1, 2025
72a2e02
chore: update multichain-account-service
zone-live Oct 7, 2025
312082e
Merge branch 'main' into feat/bip44-bitcoin
zone-live Oct 7, 2025
a84259e
chore: packages update
zone-live Oct 7, 2025
9f5fcc9
chore: update privacy-snapshot.json
zone-live Oct 7, 2025
0d2b200
Merge branch 'main' into feat/bip44-bitcoin
zone-live Oct 7, 2025
426a9e9
test: fixed mocks for create btc account
javiergarciavera Oct 8, 2025
6610c7f
test: fix lint
javiergarciavera Oct 8, 2025
5fac5b5
chore: lint fix
zone-live Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/scripts/controller-init/multichain/multichain-account-service-init.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ describe('MultichainAccountServiceInit', () => {

expect(accountTreeControllerClassMock).toHaveBeenCalledWith({
messenger: requestMock.controllerMessenger,
providers: expect.any(Array),
});
});
});
12 changes: 11 additions & 1 deletion app/scripts/controller-init/multichain/multichain-account-service-init.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
import { MultichainAccountService } from '@metamask/multichain-account-service';
import {
///: BEGIN:ONLY_INCLUDE_IF(bitcoin)
BtcAccountProvider,
///: END:ONLY_INCLUDE_IF
MultichainAccountService,
} from '@metamask/multichain-account-service';
import { ControllerInitFunction } from '../types';
import {
MultichainAccountServiceMessenger,
Expand Down Expand Up @@ -26,6 +31,11 @@ export const MultichainAccountServiceInit: ControllerInitFunction<
> = ({ controllerMessenger, initMessenger }) => {
const controller = new MultichainAccountService({
messenger: controllerMessenger,
providers: [
///: BEGIN:ONLY_INCLUDE_IF(bitcoin)
new BtcAccountProvider(controllerMessenger),
///: END:ONLY_INCLUDE_IF
],
});

const preferencesState = initMessenger.call('PreferencesController:getState');
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@
"@metamask/approval-controller": "^7.0.0",
"@metamask/assets-controllers": "patch:@metamask/assets-controllers@npm%3A78.0.0#~/.yarn/patches/@metamask-assets-controllers-npm-78.0.0-95e99a2835.patch",
"@metamask/base-controller": "^8.3.0",
"@metamask/bitcoin-wallet-snap": "^1.0.0",
"@metamask/bitcoin-wallet-snap": "^1.2.0",
"@metamask/bridge-controller": "^48.0.0",
"@metamask/bridge-status-controller": "^48.0.0",
"@metamask/browser-passworder": "^4.3.0",
Expand Down Expand Up @@ -321,7 +321,7 @@
"@metamask/message-manager": "^13.0.0",
"@metamask/message-signing-snap": "1.1.3",
"@metamask/metamask-eth-abis": "^3.1.1",
"@metamask/multichain-account-service": "^1.5.0",
"@metamask/multichain-account-service": "^1.6.0",
"@metamask/multichain-api-client": "^0.7.0",
"@metamask/multichain-api-middleware": "1.2.0",
"@metamask/multichain-network-controller": "^1.0.0",
Expand Down
1 change: 1 addition & 0 deletions privacy-snapshot.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
"bafkreifvhjdf6ve4jfv6qytqtux5nd4nwnelioeiqx5x2ez5yrgrzk7ypi.ipfs.dweb.link",
"bafybeidxfmwycgzcp4v2togflpqh2gnibuexjy4m4qqwxp7nh3jx5zlh4y.ipfs.dweb.link",
"base-mainnet.infura.io",
"bitcoin-mainnet.infura.io",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you clarify, is this functionality disabled if basic functionality is disabled?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, same as solana and any other non-evm network working from a snap

"bridge.api.cx.metamask.io",
"bridge.dev-api.cx.metamask.io",
"bsc-dataseed.binance.org",
Expand Down
Loading
Loading