feat: enable bitcoin bip44 #36510

aganglada · 2025-10-01T15:30:39Z

Description

Enable Bitcoin BIP44 accounts

Changelog

CHANGELOG entry: Enable BIP44 Bitcoin accounts

Related issues

Fixes:

Manual testing steps

Load flask/beta
Go to accounts you should see bitcoin accounts created

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Pass a providers array to MultichainAccountService, adding BtcAccountProvider behind a bitcoin build flag, and update the test accordingly.

Multichain Account Service Init (app/scripts/controller-init/multichain/multichain-account-service-init.ts):
- Add providers option when constructing MultichainAccountService.
- Include BtcAccountProvider in providers (guarded by ONLY_INCLUDE_IF(bitcoin)).
Tests (multichain-account-service-init.test.ts):
- Expect providers array in constructor args.

^{Written by Cursor Bugbot for commit b53661c. This will update automatically on new commits. Configure here.}

github-actions · 2025-10-01T15:30:54Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-10-01T15:57:16Z

📊 Page Load Benchmark Results

Current Commit: 8e5630b | Date: 10/1/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±72ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 731ms (±71ms) 🟢 | historical mean value: 738ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±13ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	72ms	1.01s	1.36s	1.26s	1.36s
domContentLoaded	731ms	71ms	698ms	1.04s	935ms	1.04s
firstPaint	76ms	13ms	56ms	184ms	84ms	184ms
firstContentfulPaint	76ms	13ms	56ms	184ms	84ms	184ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-01T15:57:20Z

Builds ready [8e5630b]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1240 ± 108 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1240	1089	2134	108	1276	1333
			load	1075	963	1891	97	1100	1145
			domContentLoaded	1069	957	1884	97	1093	1142
			domInteractive	18	14	86	9	17	39
			firstPaint	617	72	1153	425	1073	1125
			backgroundConnect	253	240	294	8	257	265
			firstReactRender	24	17	57	7	25	39
			getState	14	5	44	7	16	28
			initialActions	5	0	24	4	7	14
			loadScripts	822	710	1596	93	842	898
			setupStore	10	6	32	4	10	22
	Webpack	Home	uiStartup	1990	1556	2523	265	2182	2446
			load	1596	1231	2001	209	1740	1922
			domContentLoaded	1584	1217	1984	211	1737	1905
			domInteractive	18	12	119	16	15	53
			firstPaint	163	63	466	75	187	312
			backgroundConnect	34	17	431	53	30	56
			firstReactRender	92	38	333	72	80	317
			getState	24	4	292	56	13	192
			initialActions	6	2	18	3	6	14
			loadScripts	1581	1215	1974	210	1734	1893
			setupStore	19	5	299	45	13	20
Firefox	Browserify	Home	uiStartup	1381	1190	1749	104	1439	1557
			load	1196	1045	1442	85	1256	1346
			domContentLoaded	1196	1045	1441	85	1256	1346
			domInteractive	100	33	324	52	107	222
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	29	19	80	10	33	49
			firstReactRender	27	23	57	4	28	32
			getState	7	3	70	8	6	10
			initialActions	4	1	25	3	4	10
			loadScripts	1174	1024	1418	84	1240	1326
			setupStore	9	5	47	5	9	16
	Webpack	Home	uiStartup	1808	1537	2302	146	1912	2052
			load	1535	1271	1849	137	1624	1774
			domContentLoaded	1534	1271	1848	137	1623	1773
			domInteractive	120	41	459	65	120	299
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	37	26	167	19	41	53
			firstReactRender	43	36	77	5	46	53
			getState	7	3	21	3	8	15
			initialActions	5	1	49	5	5	11
			loadScripts	1508	1238	1822	136	1596	1754
			setupStore	14	7	165	19	11	30

Benchmark value 1241 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1076 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1070 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 253 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 265 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 14 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 22 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 14 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 29 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 222 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 10 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 1808 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1535 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1535 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 121 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 38 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1508 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 14 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 2052 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1774 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1773 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 299 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 53 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 53 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 11 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1754 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 30 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 977ms | Sum of p95 exceeds: 935.8ms
Sum of all benchmark exceeds: 1912.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -157 Bytes (0%)
ui: 1.91 KiB (0.03%)
common: 498 Bytes (0.01%)

metamaskbot · 2025-10-01T17:32:33Z

📊 Page Load Benchmark Results

Current Commit: b53661c | Date: 10/1/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±74ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 731ms (±71ms) 🟢 | historical mean value: 738ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±14ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	74ms	1.00s	1.35s	1.26s	1.35s
domContentLoaded	731ms	71ms	694ms	1.02s	940ms	1.02s
firstPaint	76ms	14ms	56ms	200ms	84ms	200ms
firstContentfulPaint	76ms	14ms	56ms	200ms	84ms	200ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-01T17:32:45Z

Builds ready [b53661c]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1224 ± 71 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1224	1096	1556	71	1265	1336
			load	1056	948	1201	63	1096	1170
			domContentLoaded	1047	919	1192	64	1089	1162
			domInteractive	19	13	149	15	16	41
			firstPaint	800	109	1237	403	1095	1170
			backgroundConnect	252	239	345	12	255	270
			firstReactRender	25	16	161	16	25	43
			getState	14	4	112	12	17	32
			initialActions	5	1	98	11	6	12
			loadScripts	804	670	951	63	846	921
			setupStore	9	6	32	4	10	21
	Webpack	Home	uiStartup	2016	1525	2536	276	2241	2488
			load	1619	1225	2005	211	1756	1943
			domContentLoaded	1611	1219	2000	211	1752	1933
			domInteractive	18	12	113	14	15	45
			firstPaint	170	61	381	70	189	330
			backgroundConnect	28	14	70	11	30	53
			firstReactRender	97	37	347	76	90	317
			getState	26	5	321	61	15	271
			initialActions	7	2	172	17	6	19
			loadScripts	1607	1217	1989	210	1749	1927
			setupStore	12	5	28	5	14	24
Firefox	Browserify	Home	uiStartup	1413	1213	1774	108	1483	1613
			load	1218	1056	1416	84	1282	1358
			domContentLoaded	1217	1055	1416	84	1282	1358
			domInteractive	105	33	344	55	111	239
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	31	19	125	14	35	53
			firstReactRender	28	24	49	4	29	32
			getState	8	3	56	10	6	31
			initialActions	4	1	14	2	4	8
			loadScripts	1194	1038	1388	82	1255	1339
			setupStore	10	5	56	7	10	15
	Webpack	Home	uiStartup	1593	1385	2142	183	1686	2036
			load	1342	1167	1770	140	1454	1617
			domContentLoaded	1342	1166	1770	140	1454	1616
			domInteractive	110	32	395	70	103	314
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	41	22	236	30	40	104
			firstReactRender	38	31	51	5	41	49
			getState	6	3	17	2	6	12
			initialActions	3	1	13	2	4	8
			loadScripts	1316	1142	1749	139	1427	1581
			setupStore	11	6	177	17	10	16

Benchmark value 801 exceeds gate value 800 for chrome browserify home mean firstPaint
Benchmark value 253 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 270 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 12 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 21 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 8 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 2488 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 271 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 19 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1413 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 31 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 239 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 31 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 8 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 111 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 41 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 2036 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 314 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 104 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 8 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 303ms | Sum of p95 exceeds: 765.8ms
Sum of all benchmark exceeds: 1068.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 4.72 KiB (0.1%)
ui: 1.6 KiB (0.02%)
common: 1.06 KiB (0.01%)

feat: enable bitcoin bip44

8e5630b

metamaskbot added the team-new-networks PRs from the New Networks team label Oct 1, 2025

github-actions bot added the size-S label Oct 1, 2025

fix: test

b53661c

aganglada self-assigned this Oct 1, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: enable bitcoin bip44 #36510

feat: enable bitcoin bip44 #36510

aganglada commented Oct 1, 2025 •

edited by cursor bot

Loading

Uh oh!

github-actions bot commented Oct 1, 2025

Uh oh!

metamaskbot commented Oct 1, 2025

Uh oh!

metamaskbot commented Oct 1, 2025

Uh oh!

metamaskbot commented Oct 1, 2025

Uh oh!

metamaskbot commented Oct 1, 2025

Uh oh!

Uh oh!

feat: enable bitcoin bip44 #36510

Are you sure you want to change the base?

feat: enable bitcoin bip44 #36510

Conversation

aganglada commented Oct 1, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Oct 1, 2025

Uh oh!

metamaskbot commented Oct 1, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 1, 2025

Uh oh!

metamaskbot commented Oct 1, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 1, 2025

Uh oh!

Uh oh!

aganglada commented Oct 1, 2025 •

edited by cursor bot

Loading