Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix for served_model_name from request.model #257

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

l4b4r4b4b4
Copy link
Contributor

passing the model name defined at statup currently produces a 404 error. This change fixes this bug.

passing the model name defined at statup currently produces a 404 error. This change fixes this bug.
@jeffreymeetkai
Copy link
Collaborator

Thanks for the fix! I've just made some refactoring in #253 which resulted in served_model = [args.model]. Thus, I've changed back to passing in served_model into process_chat_completion to actually compare request.model against the model name being loaded and served. I'll merge this after a small change in that PR. Thanks again!

Copy link
Collaborator

@jeffreymeetkai jeffreymeetkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jeffreymeetkai jeffreymeetkai merged commit df05374 into MeetKai:main Aug 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants